Skip to content

Correct ModalCommandConsequences to prevent redundant message dialogs #121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dpikhulya wants to merge 2 commits into from
Closed

Correct ModalCommandConsequences to prevent redundant message dialogs #121

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cfb6a02
Prevent unwanted message
dpikhulya Jun 23, 2025
4b38389
Bump version —> 2.0.0-SNAPSHOT.82
dpikhulya Jun 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions client/src/main/kotlin/io/spine/chords/client/layout/ModalCommandConsequences.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,14 +152,26 @@ public open class ModalCommandConsequences<C : CommandMessage>(
posting = true
}
onServerError {
// Prevent other events while the message is displayed, since the
// modal is already on the path of being closed.
cancelAllSubscriptions()

showMessage("Unexpected server error has occurred.")
close()
}
onNetworkError {
// Prevent other events while the message is displayed, since the
// modal is already on the path of being closed.
cancelAllSubscriptions()

showMessage("Server connection failed.")
close()
}
onDefaultTimeout {
// Prevent other events while the message is displayed, since the
// modal is already on the path of being closed.
cancelAllSubscriptions()

showMessage("The operation takes unexpectedly long to process. " +
"Please check the status of its execution later.")
close()
Expand Down
59 changes: 19 additions & 40 deletions dependencies.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@


# Dependencies of `io.spine.chords:spine-chords-client:2.0.0-SNAPSHOT.81`
# Dependencies of `io.spine.chords:spine-chords-client:2.0.0-SNAPSHOT.82`

## Runtime
1. **Group** : cafe.adriel.voyager. **Name** : voyager-core. **Version** : 1.0.1.**No license information found**
Expand Down Expand Up @@ -642,10 +642,7 @@
* **Project URL:** [http://jcp.org/en/jsr/detail?id=250](http://jcp.org/en/jsr/detail?id=250)
* **License:** [CDDL + GPLv2 with classpath exception](https://github.com/javaee/javax.annotation/blob/master/LICENSE)

1. **Group** : javax.inject. **Name** : javax.inject. **Version** : 1.
* **Project URL:** [http://code.google.com/p/atinject/](http://code.google.com/p/atinject/)
* **License:** [The Apache Software License, Version 2.0](http://www.apache.org/licenses/LICENSE-2.0.txt)

1. **Group** : javax.inject. **Name** : javax.inject. **Version** : 1.**No license information found**
1. **Group** : junit. **Name** : junit. **Version** : 4.13.1.
* **Project URL:** [http://junit.org](http://junit.org)
* **License:** [Eclipse Public License 1.0](http://www.eclipse.org/legal/epl-v10.html)
Expand Down Expand Up @@ -893,10 +890,7 @@
* **Project URL:** [https://github.com/JetBrains/intellij-coverage](https://github.com/JetBrains/intellij-coverage)
* **License:** [Apache License, Version 2.0](https://www.apache.org/licenses/LICENSE-2.0)

1. **Group** : org.jetbrains.intellij.deps. **Name** : trove4j. **Version** : 1.0.20200330.
* **Project URL:** [https://github.com/JetBrains/intellij-deps-trove4j](https://github.com/JetBrains/intellij-deps-trove4j)
* **License:** [GNU LESSER GENERAL PUBLIC LICENSE 2.1](https://www.gnu.org/licenses/old-licenses/lgpl-2.1.en.html)

1. **Group** : org.jetbrains.intellij.deps. **Name** : trove4j. **Version** : 1.0.20200330.**No license information found**
1. **Group** : org.jetbrains.kotlin. **Name** : kotlin-compiler-embeddable. **Version** : 1.8.21.
* **Project URL:** [https://kotlinlang.org/](https://kotlinlang.org/)
* **License:** [The Apache License, Version 2.0](http://www.apache.org/licenses/LICENSE-2.0.txt)
Expand Down Expand Up @@ -1094,12 +1088,12 @@

The dependencies distributed under several licenses, are used according their commercial-use-friendly license.

This report was generated on **Mon May 19 05:01:25 EEST 2025** using [Gradle-License-Report plugin](https://github.com/jk1/Gradle-License-Report) by Evgeny Naumenko, licensed under [Apache 2.0 License](https://github.com/jk1/Gradle-License-Report/blob/master/LICENSE).
This report was generated on **Mon Jun 23 22:17:17 EEST 2025** using [Gradle-License-Report plugin](https://github.com/jk1/Gradle-License-Report) by Evgeny Naumenko, licensed under [Apache 2.0 License](https://github.com/jk1/Gradle-License-Report/blob/master/LICENSE).




# Dependencies of `io.spine.chords:spine-chords-codegen-tests:2.0.0-SNAPSHOT.81`
# Dependencies of `io.spine.chords:spine-chords-codegen-tests:2.0.0-SNAPSHOT.82`

## Runtime
1. **Group** : com.google.android. **Name** : annotations. **Version** : 4.1.1.4.
Expand Down Expand Up @@ -1609,10 +1603,7 @@ This report was generated on **Mon May 19 05:01:25 EEST 2025** using [Gradle-Lic
* **Project URL:** [http://jcp.org/en/jsr/detail?id=250](http://jcp.org/en/jsr/detail?id=250)
* **License:** [CDDL + GPLv2 with classpath exception](https://github.com/javaee/javax.annotation/blob/master/LICENSE)

1. **Group** : javax.inject. **Name** : javax.inject. **Version** : 1.
* **Project URL:** [http://code.google.com/p/atinject/](http://code.google.com/p/atinject/)
* **License:** [The Apache Software License, Version 2.0](http://www.apache.org/licenses/LICENSE-2.0.txt)

1. **Group** : javax.inject. **Name** : javax.inject. **Version** : 1.**No license information found**
1. **Group** : junit. **Name** : junit. **Version** : 4.13.1.
* **Project URL:** [http://junit.org](http://junit.org)
* **License:** [Eclipse Public License 1.0](http://www.eclipse.org/legal/epl-v10.html)
Expand Down Expand Up @@ -1770,10 +1761,7 @@ This report was generated on **Mon May 19 05:01:25 EEST 2025** using [Gradle-Lic
* **Project URL:** [https://github.com/JetBrains/intellij-coverage](https://github.com/JetBrains/intellij-coverage)
* **License:** [Apache License, Version 2.0](https://www.apache.org/licenses/LICENSE-2.0)

1. **Group** : org.jetbrains.intellij.deps. **Name** : trove4j. **Version** : 1.0.20200330.
* **Project URL:** [https://github.com/JetBrains/intellij-deps-trove4j](https://github.com/JetBrains/intellij-deps-trove4j)
* **License:** [GNU LESSER GENERAL PUBLIC LICENSE 2.1](https://www.gnu.org/licenses/old-licenses/lgpl-2.1.en.html)

1. **Group** : org.jetbrains.intellij.deps. **Name** : trove4j. **Version** : 1.0.20200330.**No license information found**
1. **Group** : org.jetbrains.kotlin. **Name** : kotlin-compiler-embeddable. **Version** : 1.8.21.
* **Project URL:** [https://kotlinlang.org/](https://kotlinlang.org/)
* **License:** [The Apache License, Version 2.0](http://www.apache.org/licenses/LICENSE-2.0.txt)
Expand Down Expand Up @@ -1953,12 +1941,12 @@ This report was generated on **Mon May 19 05:01:25 EEST 2025** using [Gradle-Lic

The dependencies distributed under several licenses, are used according their commercial-use-friendly license.

This report was generated on **Mon May 19 05:01:27 EEST 2025** using [Gradle-License-Report plugin](https://github.com/jk1/Gradle-License-Report) by Evgeny Naumenko, licensed under [Apache 2.0 License](https://github.com/jk1/Gradle-License-Report/blob/master/LICENSE).
This report was generated on **Mon Jun 23 22:17:21 EEST 2025** using [Gradle-License-Report plugin](https://github.com/jk1/Gradle-License-Report) by Evgeny Naumenko, licensed under [Apache 2.0 License](https://github.com/jk1/Gradle-License-Report/blob/master/LICENSE).




# Dependencies of `io.spine.chords:spine-chords-core:2.0.0-SNAPSHOT.81`
# Dependencies of `io.spine.chords:spine-chords-core:2.0.0-SNAPSHOT.82`

## Runtime
1. **Group** : cafe.adriel.voyager. **Name** : voyager-core. **Version** : 1.0.1.
Expand Down Expand Up @@ -2531,10 +2519,7 @@ This report was generated on **Mon May 19 05:01:27 EEST 2025** using [Gradle-Lic
* **Project URL:** [http://jcp.org/en/jsr/detail?id=250](http://jcp.org/en/jsr/detail?id=250)
* **License:** [CDDL + GPLv2 with classpath exception](https://github.com/javaee/javax.annotation/blob/master/LICENSE)

1. **Group** : javax.inject. **Name** : javax.inject. **Version** : 1.
* **Project URL:** [http://code.google.com/p/atinject/](http://code.google.com/p/atinject/)
* **License:** [The Apache Software License, Version 2.0](http://www.apache.org/licenses/LICENSE-2.0.txt)

1. **Group** : javax.inject. **Name** : javax.inject. **Version** : 1.**No license information found**
1. **Group** : junit. **Name** : junit. **Version** : 4.13.1.
* **Project URL:** [http://junit.org](http://junit.org)
* **License:** [Eclipse Public License 1.0](http://www.eclipse.org/legal/epl-v10.html)
Expand Down Expand Up @@ -2982,12 +2967,12 @@ This report was generated on **Mon May 19 05:01:27 EEST 2025** using [Gradle-Lic

The dependencies distributed under several licenses, are used according their commercial-use-friendly license.

This report was generated on **Mon May 19 05:01:30 EEST 2025** using [Gradle-License-Report plugin](https://github.com/jk1/Gradle-License-Report) by Evgeny Naumenko, licensed under [Apache 2.0 License](https://github.com/jk1/Gradle-License-Report/blob/master/LICENSE).
This report was generated on **Mon Jun 23 22:17:24 EEST 2025** using [Gradle-License-Report plugin](https://github.com/jk1/Gradle-License-Report) by Evgeny Naumenko, licensed under [Apache 2.0 License](https://github.com/jk1/Gradle-License-Report/blob/master/LICENSE).




# Dependencies of `io.spine.chords:spine-chords-proto:2.0.0-SNAPSHOT.81`
# Dependencies of `io.spine.chords:spine-chords-proto:2.0.0-SNAPSHOT.82`

## Runtime
1. **Group** : cafe.adriel.voyager. **Name** : voyager-core. **Version** : 1.0.1.**No license information found**
Expand Down Expand Up @@ -3562,10 +3547,7 @@ This report was generated on **Mon May 19 05:01:30 EEST 2025** using [Gradle-Lic
* **Project URL:** [http://jcp.org/en/jsr/detail?id=250](http://jcp.org/en/jsr/detail?id=250)
* **License:** [CDDL + GPLv2 with classpath exception](https://github.com/javaee/javax.annotation/blob/master/LICENSE)

1. **Group** : javax.inject. **Name** : javax.inject. **Version** : 1.
* **Project URL:** [http://code.google.com/p/atinject/](http://code.google.com/p/atinject/)
* **License:** [The Apache Software License, Version 2.0](http://www.apache.org/licenses/LICENSE-2.0.txt)

1. **Group** : javax.inject. **Name** : javax.inject. **Version** : 1.**No license information found**
1. **Group** : junit. **Name** : junit. **Version** : 4.13.1.
* **Project URL:** [http://junit.org](http://junit.org)
* **License:** [Eclipse Public License 1.0](http://www.eclipse.org/legal/epl-v10.html)
Expand Down Expand Up @@ -4010,12 +3992,12 @@ This report was generated on **Mon May 19 05:01:30 EEST 2025** using [Gradle-Lic

The dependencies distributed under several licenses, are used according their commercial-use-friendly license.

This report was generated on **Mon May 19 05:01:33 EEST 2025** using [Gradle-License-Report plugin](https://github.com/jk1/Gradle-License-Report) by Evgeny Naumenko, licensed under [Apache 2.0 License](https://github.com/jk1/Gradle-License-Report/blob/master/LICENSE).
This report was generated on **Mon Jun 23 22:17:26 EEST 2025** using [Gradle-License-Report plugin](https://github.com/jk1/Gradle-License-Report) by Evgeny Naumenko, licensed under [Apache 2.0 License](https://github.com/jk1/Gradle-License-Report/blob/master/LICENSE).




# Dependencies of `io.spine.chords:spine-chords-proto-values:2.0.0-SNAPSHOT.81`
# Dependencies of `io.spine.chords:spine-chords-proto-values:2.0.0-SNAPSHOT.82`

## Runtime
1. **Group** : com.google.code.findbugs. **Name** : jsr305. **Version** : 3.0.2.
Expand Down Expand Up @@ -4465,10 +4447,7 @@ This report was generated on **Mon May 19 05:01:33 EEST 2025** using [Gradle-Lic
* **Project URL:** [http://jcp.org/en/jsr/detail?id=250](http://jcp.org/en/jsr/detail?id=250)
* **License:** [CDDL + GPLv2 with classpath exception](https://github.com/javaee/javax.annotation/blob/master/LICENSE)

1. **Group** : javax.inject. **Name** : javax.inject. **Version** : 1.
* **Project URL:** [http://code.google.com/p/atinject/](http://code.google.com/p/atinject/)
* **License:** [The Apache Software License, Version 2.0](http://www.apache.org/licenses/LICENSE-2.0.txt)

1. **Group** : javax.inject. **Name** : javax.inject. **Version** : 1.**No license information found**
1. **Group** : junit. **Name** : junit. **Version** : 4.13.1.
* **Project URL:** [http://junit.org](http://junit.org)
* **License:** [Eclipse Public License 1.0](http://www.eclipse.org/legal/epl-v10.html)
Expand Down Expand Up @@ -4809,12 +4788,12 @@ This report was generated on **Mon May 19 05:01:33 EEST 2025** using [Gradle-Lic

The dependencies distributed under several licenses, are used according their commercial-use-friendly license.

This report was generated on **Mon May 19 05:01:35 EEST 2025** using [Gradle-License-Report plugin](https://github.com/jk1/Gradle-License-Report) by Evgeny Naumenko, licensed under [Apache 2.0 License](https://github.com/jk1/Gradle-License-Report/blob/master/LICENSE).
This report was generated on **Mon Jun 23 22:17:28 EEST 2025** using [Gradle-License-Report plugin](https://github.com/jk1/Gradle-License-Report) by Evgeny Naumenko, licensed under [Apache 2.0 License](https://github.com/jk1/Gradle-License-Report/blob/master/LICENSE).




# Dependencies of `io.spine.chords:spine-chords-runtime:2.0.0-SNAPSHOT.81`
# Dependencies of `io.spine.chords:spine-chords-runtime:2.0.0-SNAPSHOT.82`

## Runtime
1. **Group** : com.google.code.findbugs. **Name** : jsr305. **Version** : 3.0.2.
Expand Down Expand Up @@ -5578,4 +5557,4 @@ This report was generated on **Mon May 19 05:01:35 EEST 2025** using [Gradle-Lic

The dependencies distributed under several licenses, are used according their commercial-use-friendly license.

This report was generated on **Mon May 19 05:01:37 EEST 2025** using [Gradle-License-Report plugin](https://github.com/jk1/Gradle-License-Report) by Evgeny Naumenko, licensed under [Apache 2.0 License](https://github.com/jk1/Gradle-License-Report/blob/master/LICENSE).
This report was generated on **Mon Jun 23 22:17:30 EEST 2025** using [Gradle-License-Report plugin](https://github.com/jk1/Gradle-License-Report) by Evgeny Naumenko, licensed under [Apache 2.0 License](https://github.com/jk1/Gradle-License-Report/blob/master/LICENSE).
2 changes: 1 addition & 1 deletion pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ all modules and does not describe the project structure per-subproject.
-->
<groupId>io.spine.chords</groupId>
<artifactId>Chords</artifactId>
<version>2.0.0-SNAPSHOT.81</version>
<version>2.0.0-SNAPSHOT.82</version>

<inceptionYear>2015</inceptionYear>

Expand Down
2 changes: 1 addition & 1 deletion version.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,4 +27,4 @@
/**
* The version of all Chords libraries.
*/
val chordsVersion: String by extra("2.0.0-SNAPSHOT.81")
val chordsVersion: String by extra("2.0.0-SNAPSHOT.82")
Loading