More on generated routing#183
Merged
alexander-yevsyukov merged 31 commits intomasterfrom Feb 26, 2025
Merged
Conversation
Also: * Improve docs.
Comment on lines
69
to
71
| lamp = context.readState(l1) | ||
| // The command was handled via custom routing declared in the class. | ||
| lamp.state shouldBe State.ON |
Contributor
There was a problem hiding this comment.
Suggested change
| lamp = context.readState(l1) | |
| // The command was handled via custom routing declared in the class. | |
| lamp.state shouldBe State.ON | |
| // The command was handled via custom routing declared in the class. | |
| lamp = context.readState(l1) | |
| lamp.state shouldBe State.ON |
I would put these comments above the block, so that there is an empty before a comment. Then, it is easier to read them.
| fun route(e: RoomEvent): RoomId = e.room | ||
|
|
||
| /** | ||
| * The routing function by event class. |
Contributor
There was a problem hiding this comment.
Suggested change
| * The routing function by event class. | |
| * The routing function accepting the event class. |
So that the both method are documented in the same style.
| super.setupEventRouting(routing) | ||
| @Assign | ||
| internal fun handle(c: AddDevice): DeviceAdded = | ||
| deviceAdded { device = c.device; name = c.name } |
Contributor
There was a problem hiding this comment.
Why to have them on the same line? The methods below don't do that.
Contributor
Author
There was a problem hiding this comment.
Because these functions generate events, while appliers update the state.
Also, I'm experimenting with the compact style for code which merely transforms a command into an event without doing much work.
mc-java-routing/src/main/kotlin/io/spine/tools/mc/java/routing/proessor/CommonChecks.kt
Outdated
Show resolved
Hide resolved
mc-java-routing/src/main/kotlin/io/spine/tools/mc/java/routing/proessor/CommonChecks.kt
Show resolved
Hide resolved
mc-java-routing/src/main/kotlin/io/spine/tools/mc/java/routing/proessor/EntityClass.kt
Outdated
Show resolved
Hide resolved
Comment on lines
36
to
37
| * @param F The type of route functions handled by the visitor. | ||
| * @param setup The type of the routing setup class generated by this visitor. |
Contributor
There was a problem hiding this comment.
Please have an empty line before the constructor parameters.
...ava-routing/src/main/kotlin/io/spine/tools/mc/java/routing/proessor/MulticastRouteVisitor.kt
Show resolved
Hide resolved
Comment on lines
56
to
57
| * The base class for code generators implementing routing setup classes | ||
| * adding calls to the type of route functions specified by the generic parameter [F]. |
Contributor
There was a problem hiding this comment.
This sentence is hard to understand.
Comment on lines
148
to
149
| // Not duplicated. | ||
| it shouldNotContain "DeviceRegistered" |
Contributor
There was a problem hiding this comment.
Suggested change
| // Not duplicated. | |
| it shouldNotContain "DeviceRegistered" | |
| // This event should not be duplicated. | |
| it shouldNotContain "DeviceRegistered" |
Also: * Test message parameter name restriction.
armiol
approved these changes
Feb 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR continues work on generating routing setup classes.
Changes in details
StateRoutingSetupwas implemented.StateUdateRouteVisitorandEventRouteVisitorgot an abstract baseMulticastRouteVisitorbecause the code generated inside therunblock is basically the same with the only difference with the parameter types.Logger.error().