fix(#105): ensure consistent requestId in all error payloads#127
Open
Elite-tch wants to merge 1 commit intoSplit-Naira:mainfrom
Open
fix(#105): ensure consistent requestId in all error payloads#127Elite-tch wants to merge 1 commit intoSplit-Naira:mainfrom
Elite-tch wants to merge 1 commit intoSplit-Naira:mainfrom
Conversation
|
@Elite-tch Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Contributor
|
pls kindly resolve conflicts @Elite-tch |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix(#105): Consistent requestId in all error payloads
Closes #105
This PR:
Adds requestId to every 4xx response in POST /:projectId/distribute and GET /:projectId/history .
Updates the global errorHandler to detect RequestValidationError and return a 400 instead of masking it as a 500
Adds 18 contract tests ( splits.contract.test.ts ) that assert { error, message, requestId } is present on all error responses across every route
All 18 tests pass.