Skip to content

Conversation

@Vanessa-SSY
Copy link

@Vanessa-SSY Vanessa-SSY commented Dec 3, 2024

A summary of your pull request, including the what change you're making and why.

Testing

Include any additional information about the testing you have completed to
ensure your changes behave as expected. For a speedy review, please check
any of the tasks you completed below during your testing.

  • Added unit tests for new functionality
  • Tested end-to-end using the local server
  • [If destination is already live] Tested for backward compatibility of destination. Note: New required fields are a breaking change.
  • [Segmenters] Tested in the staging environment
  • [Segmenters] [If applicable for this change] Tested for regression with Hadron.

joe-ayoub-segment and others added 22 commits November 19, 2024 10:39
* Add dropdown for all privacy mappings

* Add lower case in storage consents

* Add unit test

* Add dropdowns
* New Drip description

* Publish (segmentio#2602)

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

---------

Co-authored-by: Joe Ayoub <joe.ayoub@segment.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
* Updated error reporter MultiStatus property
* Updated test cases
* build: migrate to rpub rsec based auth

* build: updates for authentication tests

* build: small tweaks and test fixes

* Update packages/destination-actions/src/destinations/rokt-audiences/upsertCustomAudiences/index.ts

Co-authored-by: Joe Ayoub <45374896+joe-ayoub-segment@users.noreply.github.com>

---------

Co-authored-by: Joe Ayoub <45374896+joe-ayoub-segment@users.noreply.github.com>
* Add mirror mode

* Adjust checks to be backwards compatible

* Add unit tests
* Saving progress

* Update packages/destination-actions/src/destinations/attentive/index.ts

Co-authored-by: Joe Ayoub <45374896+joe-ayoub-segment@users.noreply.github.com>

* Update packages/destination-actions/src/destinations/attentive/customEvents/index.ts

Co-authored-by: Joe Ayoub <45374896+joe-ayoub-segment@users.noreply.github.com>

* Update packages/destination-actions/src/destinations/attentive/customEvents/index.ts

Co-authored-by: Joe Ayoub <45374896+joe-ayoub-segment@users.noreply.github.com>

* Update packages/destination-actions/src/destinations/attentive/customEvents/index.ts

Co-authored-by: Joe Ayoub <45374896+joe-ayoub-segment@users.noreply.github.com>

* Update packages/destination-actions/src/destinations/attentive/customEvents/index.ts

Co-authored-by: Joe Ayoub <45374896+joe-ayoub-segment@users.noreply.github.com>

* Update packages/destination-actions/src/destinations/attentive/customEvents/index.ts

Co-authored-by: Joe Ayoub <45374896+joe-ayoub-segment@users.noreply.github.com>

* Update packages/destination-actions/src/destinations/attentive/customEvents/index.ts

Co-authored-by: Joe Ayoub <45374896+joe-ayoub-segment@users.noreply.github.com>

* Update packages/destination-actions/src/destinations/attentive/customEvents/index.ts

Co-authored-by: Joe Ayoub <45374896+joe-ayoub-segment@users.noreply.github.com>

* Update packages/destination-actions/src/destinations/attentive/customEvents/index.ts

Co-authored-by: Joe Ayoub <45374896+joe-ayoub-segment@users.noreply.github.com>

* Update packages/destination-actions/src/destinations/attentive/customEvents/index.ts

Co-authored-by: Joe Ayoub <45374896+joe-ayoub-segment@users.noreply.github.com>

* Update index.ts

Added default mapping for phone field

* refacting the fields and request

* correcting yarn version

* minor tweaks

* minor tweaks

* adding types

* Update index.test.ts

* Update index.test.ts

* Update index.test.ts

* Update index.test.ts

* adding types

* New endpoints

* added of endpoints

* bug fixes

* config file added

* index updates

* updating snapshot and fixing a field type issue

* adding a unit test

* new unit test

* fixing breaking test

* removing snapshot

---------

Co-authored-by: Joe Ayoub <45374896+joe-ayoub-segment@users.noreply.github.com>
Co-authored-by: Joe Ayoub <joe.ayoub@segment.com>
…lete events (segmentio#2599)

* Added OnDelete

* Fix(ITE-146) Rethrow Error
…segmentio#2604)

* adding user attribute support

* saving progress

* adding file

* adding support for custom_fields

* updating description for custom field

* coercing all user attributes to strings

* updating types
…d or not (segmentio#2616)

Co-authored-by: Gaurav Kochar <gaurav.kochar@segment.com>
* Twilio Messaging init

* updates

* saving progress

* saving progress

* saving progress

* adding field UI dependencies

* minor refactor

* after some initial testing

* refactoring dynamic functions

* refactoring

* refactoring

* saving progress

* saving progress

* saving progress

* spelling correction

* renaming Action and removing tests for now

* removing console logs

* fixing typing issue
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
(cherry picked from commit 6e6768b)
@Vanessa-SSY Vanessa-SSY force-pushed the vs/fix-external-provider branch from 6e6768b to ab01ce6 Compare December 3, 2024 20:14
@Vanessa-SSY Vanessa-SSY closed this Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.