refactor(adf): replace patcher switch with handler map#20
Merged
SmartBrandStrategies merged 1 commit intomainfrom Mar 3, 2026
Merged
refactor(adf): replace patcher switch with handler map#20SmartBrandStrategies merged 1 commit intomainfrom
SmartBrandStrategies merged 1 commit intomainfrom
Conversation
…pers Extract checkBounds() and parseColonEntry() helpers to eliminate 4 repeated index bounds checks and 2 duplicated colon-parsing blocks. Replace applyOne() switch statement with a keyed handler map for easier extension. Closes #12 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
applyOne()switch statement with keyed handler map for easier extensioncheckBounds()helper to eliminate 4 repeated index bounds checksparseColonEntry()helper to eliminate 2 duplicated colon-parsing blocksCloses #12
Test plan
pnpm run buildcleanpnpm run test— 243 tests pass🤖 Generated with Claude Code