fix: remove duplicate LLMProviders.fromEnv() method#48
Merged
stackbilt-admin merged 1 commit intomainfrom Apr 21, 2026
Merged
Conversation
Commit 33aaf53 added a new feature-complete `fromEnv(env, overrides?)` at class-body top but left the older 3-provider `fromEnv(env)` in place at class-body bottom. TypeScript 5.x catches this as TS2393 "Duplicate function implementation" so downstream CI builds (e.g. foodfiles Charter check) fail at `tsc` on `npm install`. The surviving method is a strict superset: - 5 providers (anthropic, openai, groq, cerebras, cloudflare) vs the old 3 (cloudflare, groq, cerebras) - FromEnvOverrides hook for defaultProvider, costOptimization, enableCircuitBreaker, enableRetries, fallbackRules, ledger, quotaHook, quotaFailPolicy, hooks - Throws ConfigurationError on no providers detected (safer default than the old silent `defaultProvider: 'auto'` fallback) Back-compatible with existing 1-arg callers (`LLMProviders.fromEnv(env)`) because the second param is optional. All 229 tests pass. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Commit `33aaf53` added a new feature-complete `fromEnv(env, overrides?)` at class-body top but left the older 3-provider `fromEnv(env)` in place at class-body bottom. TypeScript 5.x catches this as `TS2393 Duplicate function implementation` so downstream CI builds fail at `tsc` on `npm install`.
Blocks `Stackbilt-dev/foodfiles#116` (Charter CI green needed to merge FoodFiles auth path fix).
What changed
Deleted the older `fromEnv(env)` stub (src/index.ts:377-395). Surviving method at :218 is a strict superset:
Back-compatible with existing 1-arg callers (`LLMProviders.fromEnv(env)`) because the second param is optional.
Test plan
🤖 Generated with Claude Code