Open
Conversation
FilledStacks
requested changes
Dec 12, 2024
Contributor
FilledStacks
left a comment
FilledStacks
left a comment
There was a problem hiding this comment.
Happy with the implementation besides the library addition.
I have a question about that below.
| @@ -1,4 +1,5 @@ | |||
| /// Stores all the commands used throughout the app that | |||
| library; | |||
Contributor
There was a problem hiding this comment.
Why has this been added?
Contributor
Author
There was a problem hiding this comment.
Auto added by linter.
linter: "Dangling library doc comment. Add a 'library' directive after the library comment."
has no effect other than for the auto generated API reference (not sure what the difference is though). Would change the above comment to "//" or keep library.
Contributor
Author
There was a problem hiding this comment.
guessing it means the file will be added under "Libraries" in the attached picture with all constants documented.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes Stacked-Org/stacked#1140
Add offline_mode to stacked.json config to using stacked cli offline. It does so by passing the flag --no-pub to flutter run build_runner build. "offline mode" is of course just a suggestion easily changed by a maintainer or at the request of a maintainer.
This does pass tests apart from two which did not pass on the main branch either, I considered fixing them out of scope of this PR.