Migrate from pubspec_yaml to yaml and improve version parsing on Windows#56
Migrate from pubspec_yaml to yaml and improve version parsing on Windows#56KickNext wants to merge 1 commit intoStacked-Org:mainfrom
pubspec_yaml to yaml and improve version parsing on Windows#56Conversation
|
Did you manage to identify why the issues descibed in additional fixes occurred? I've found there are a few instances where using windows causes problems (see #52). Also, are there any tests you feel should be added? |
|
@Pebkac03 I spent an hour trying to reproduce the issue, and it seems I just overdid it. The extra As a result, I encountered a parsing error since In all the scenarios I came across, Regarding tests: it might make sense to fetch the latest I didn’t generate tests since they are generated in Actions. Without this fix, my team and I can't use the latest version of Upd: ArgResults removes the first layer of quotes from what goes into Stacked-Org/stacked#1146 Very similar to the same thing, |
|
@FilledStacks @Pebkac03 I have rebuilt the branch on the latest version without unnecessary history and without modifying version parsing, as it has been properly fixed in commit 5c21c57. I didn't consider that the version number could be more complex |
Summary
Replaced
pubspec_yamlwithyamlfor parsingpubspec.yaml, aspubspec_yamlhas not been updated for three years and breaks when parsingpubspec.yamlfiles containing modern dependency imports from external pub servers with thehostedparameter.Reproduction Example
To reproduce the issue, add the following dependency to
pubspec.yaml:The
pubspec_yamlparser fails to handle this format correctly.Additional FixesImproved version parsing. Previously, when running locally on Windows, the extracted version string included an unwanted path at the end. This issue has been resolved.