product list: reduce instances visited#46
Merged
grg merged 2 commits intoStanfordVLSI:masterfrom Mar 12, 2026
Merged
Conversation
Reduce the number of instances visited when traversing the instance tree and building the instance list. This is done by halting traversal down a branch when we encounter an instance with a filename we've previously encountered. Need to have separate tracking for synth and verif file names as Manager::create_product_lists wants to know if a module is in both the verify and synth lists. (Although this could potentially be simplified too.) In a test design, the number of nodes visited dropped from over 500K to 12K. Runtime dropped from 29.5s -> 27.1s (avg over 5 runs each).
steveri
approved these changes
Mar 12, 2026
Contributor
steveri
left a comment
steveri
left a comment
There was a problem hiding this comment.
Nice! Knuth would be proud.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reduce the number of instances visited when traversing the instance tree and building the instance list. This is done by halting traversal down a branch when we encounter an instance with a filename we've previously encountered. Need to have separate tracking for synth and verif file names as Manager::create_product_lists wants to know if a module is in both the verify and synth lists. (Although this could potentially be simplified too.)
In a test design, the number of nodes visited dropped from over 500K to 12K. Runtime dropped from 29.5s -> 27.1s (avg over 5 runs each).