attempt to improve siege formula #1915
Merged
BadM0dder merged 4 commits intoStarCoreSE:mainfrom Mar 6, 2025
Merged
Conversation
found an issue of discontinuity in the siege math, this should fix it. Set min siege time from 15 -> 20 for now. The issue was any time spent in siege between 8 seconds and 15 seconds was worth an incorrect 15 seconds of cooldown, and the 16th second was worth a correct 32 seconds of cooldown. Now there is a smooth transition, the first 10 seconds are worth 20 seconds of cooldown, and the 11th second is 22s of cooldown, the 12th second is 24s of cooldown, etc. Tested and confirmed to work in single player.
ari-steas
pushed a commit
that referenced
this pull request
Mar 20, 2025
Tested and confirmed to work in single player.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
found an issue of discontinuity in the siege math, this should fix it. Set min siege time from 15 -> 20 for now.
The issue was any time spent in siege between 8 seconds and 15 seconds was worth an incorrect 15 seconds of cooldown, and the 16th second was worth a correct 32 seconds of cooldown.
Now there is a smooth transition, the first 10 seconds are worth 20 seconds of cooldown, and the 11th second is 22s of cooldown, the 12th second is 24s of cooldown, etc.
Tested and confirmed to work in single player.