Show loading spinner while model initializes#116
Open
rakendd wants to merge 1 commit intoStarmel:masterfrom
Open
Show loading spinner while model initializes#116rakendd wants to merge 1 commit intoStarmel:masterfrom
rakendd wants to merge 1 commit intoStarmel:masterfrom
Conversation
The record button was silently disabled during model loading (isLoading=true) with no visual feedback, making it appear broken. This adds the isLoading state to the spinner condition so users can see the model is still initializing.
Owner
|
The app displays a model loading indicator. What is the purpose of the progress bar on the button, which is blocked during loading and while the loading indicator is already displayed on the screen? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
isLoading=true), but shows no visual feedback — it looks like a normal clickable buttonlarge-v3-turbo(1.5GB) which take ~30 seconds to loadviewModel.transcriptionService.isLoadingto the spinner condition so the loading indicator is shown during model initializationChange
One-line change in
ContentView.swift:Test plan
large-v3-turbo)