Add audio playback preservation feature#49
Open
halapenyoharry wants to merge 2 commits intoStarmel:masterfrom
Open
Add audio playback preservation feature#49halapenyoharry wants to merge 2 commits intoStarmel:masterfrom
halapenyoharry wants to merge 2 commits intoStarmel:masterfrom
Conversation
- Configure AVAudioSession to mix with other audio - Prevents interrupting music, podcasts, or other audio playback - Uses .mixWithOthers option to allow concurrent audio - Maintains audio session activation for consistent behavior This fixes the issue where starting dictation would stop any playing audio. The app now respects the user's audio environment and allows dictation while music or other audio continues playing in the background.
- Replace AVAudioSession (iOS-only) with AVAudioEngine approach - Use audio taps to capture input without interrupting playback - Fallback to standard AVAudioRecorder if engine setup fails - Maintains same audio format (16kHz, mono, 16-bit PCM) for Whisper This provides a proper macOS solution that allows dictation while music or other audio continues playing in the background.
Owner
|
Thanks. Will check later. |
Owner
|
Not working. Please check yourself. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Problem
Currently, when OpenSuperWhisper starts recording, it interrupts any playing audio (music, podcasts, etc.). This is the default AVAudioSession behavior but creates a poor user experience for those who want to dictate while listening to audio.
Solution
This PR configures AVAudioSession with the
.mixWithOthersoption, which allows:Technical Details
setupAudioSession()method to configure audio session on initialization.playAndRecordcategory with.mixWithOthers,.defaultToSpeaker, and.allowBluetoothoptionsTesting
Related Issues
This addresses a common pain point mentioned in various dictation app discussions where users want to dictate notes while listening to music or podcasts.
🤖 Generated with Claude Code