Skip to content

Conversation

@AsakuraMizu
Copy link
Contributor

Adapt to Starry-OS/arceos#19.

This is in preparation for a smoother transition to the new version of arceos.

@AsakuraMizu AsakuraMizu requested review from Mivik and Copilot November 26, 2025 12:51
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR refactors the codebase to adapt to changes in the axtask module API (arceos PR #19), updating task extension types and async polling patterns throughout the system.

  • Renamed TaskExtProxy to AxTaskExt across task creation code
  • Replaced Poller API with new poll_io and block_on functions for async I/O operations
  • Updated spawn calls to spawn_with_name where task names are provided
  • Added .unwrap() to task.join() call to handle new return type

Reviewed changes

Copilot reviewed 19 out of 20 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
src/entry.rs Updated task extension type and added unwrap to join call
core/src/config/*.rs Reformatted kernel stack size constant with underscore separator
arceos Updated submodule commit reference
api/src/vfs/dev/tty/ntty.rs Changed IRQ waker registration import path
api/src/vfs/dev/tty.rs Migrated from Poller to poll_io/block_on pattern
api/src/vfs/dev/log.rs Updated spawn to spawn_with_name
api/src/vfs/dev/fb.rs Updated spawn to spawn_with_name
api/src/terminal/ldisc.rs Migrated polling logic to poll_io/block_on pattern
api/src/syscall/task/clone.rs Updated task extension type name
api/src/syscall/io_mpx/*.rs Migrated select/poll/epoll from Poller to timeout+poll_io pattern
api/src/file/*.rs Migrated file I/O operations from Poller to poll_io/block_on pattern

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@AsakuraMizu AsakuraMizu merged commit cdcd4f4 into main Nov 27, 2025
12 checks passed
@AsakuraMizu AsakuraMizu deleted the refactor/axtask branch November 27, 2025 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants