-
Notifications
You must be signed in to change notification settings - Fork 53
feat(vdso): add vDSO support #66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR adds vDSO (virtual Dynamic Shared Object) support to Starry OS, enabling faster system calls by providing a user-space accessible shared memory region with kernel data. The implementation integrates with the ELF loader to map vDSO pages into user address spaces and provides platform-specific initialization for aarch64 timer access.
Key changes:
- Adds new vDSO module with ELF parsing and memory mapping logic for vDSO and VVAR pages
- Integrates vDSO loading into the ELF loader pipeline during process creation
- Initializes vDSO data structures and enables timer counter access on aarch64
Reviewed changes
Copilot reviewed 8 out of 9 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| core/src/vdso.rs | New module implementing vDSO loading, ELF parsing, memory mapping, and VVAR region setup |
| core/src/mm.rs | Integrates vDSO loading into ELF loader after auxv generation |
| core/src/lib.rs | Exports the new vdso module |
| core/Cargo.toml | Adds starry-vdso dependency |
| api/src/lib.rs | Initializes vDSO data and enables aarch64 timer access, registers vDSO update callback |
| api/Cargo.toml | Adds starry-vdso dependency |
| api/src/syscall/fs/signalfd.rs | Code formatting changes (import reordering and whitespace cleanup) |
| Cargo.toml | Adds starry-vdso workspace dependency |
| Cargo.lock | Dependency lock file updates for new starry-vdso package and its transitive dependencies |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
I'm going to give some suggestions on https://github.com/Starry-OS/starry-vdso first. |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Description
A clear and concise description of what this PR does and what changes it makes.
Type of Change
Please check the applicable options:
Related Issue
Related Issue (if any): #(issue number)
Changes
Detailed description of the changes made in this PR:
cargo fmt.Elfloader.loadto load vDSO data.load_vdso_dataand related functions.Testing
Describe how you tested these changes:
cargo fmt)Checklist
Before submitting the PR, please ensure:
cargo clippycheckscargo fmtAdditional Context
Add any other context about this PR here.
Need update starry-signal version.