Fix waitpid UAF, correct PR_SET_MM handling, add mincore stub #95
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In sys_waitpid, child.pid() and child.exit_code() were read after calling child.free(), which could lead to use-after-free issues.
Fix: Read pid and exit_code before calling free().
File:
api/src/syscall/task/ctl.rsBug Description:
The
prctlsyscall was incorrectly matchingPR_SET_MM_*constants at the top level instead of as sub-options ofPR_SET_MM.Fix:
Restructured the match to properly handle
PR_SET_MMwith its sub-options:File:
api/src/syscall/mm/mmap.rsDescription:
Added
sys_mincorethat returnsENOSYS(Unsupported). This is safer than returning incorrect data and lets programs use fallback logic.