map data type function for sQTL contexts#367
Closed
Chunmingl wants to merge 3 commits intoStatFunGen:mainfrom
Closed
map data type function for sQTL contexts#367Chunmingl wants to merge 3 commits intoStatFunGen:mainfrom
Chunmingl wants to merge 3 commits intoStatFunGen:mainfrom
Conversation
gaow
reviewed
Mar 25, 2025
| map_data_type <- function(data_type_table, context_names){ | ||
| data_type <- lapply(context_names, function(context){ | ||
| xqtl_type_table$type[apply(xqtl_type_table, 1, function(x) { | ||
| if (! grepl("sQTL",context)) { |
Contributor
There was a problem hiding this comment.
@Chunmingl am not entirely sure what we are trying to do here but anything hard-coded is not good. If you want to map data, we should take proper regular expression (search for " regex in R" ) then we provide some external files called qtl_type_mapping that look like this:
sQTL, "clu_(\\d+_[+-.]):"
which is the pattern for sQTL event names.
Contributor
There was a problem hiding this comment.
just as an exmaple. Then you load this external file and use this to help you identify the correct data types
Contributor
Author
There was a problem hiding this comment.
got it, I will update the function using regex
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.