qtwas weights: adapt to fdr/qvalue variable selection#454
Merged
gaow merged 3 commits intoStatFunGen:mainfrom Mar 30, 2026
Merged
qtwas weights: adapt to fdr/qvalue variable selection#454gaow merged 3 commits intoStatFunGen:mainfrom
gaow merged 3 commits intoStatFunGen:mainfrom
Conversation
Collaborator
al4225
commented
Mar 30, 2026
al4225
commented
- Add screen_method parameter to allow choosing between qvalue/fdr screening
- Make pre_filter_by_pqr optional (default FALSE) to skip p-value pre-filtering
- Expose initial_corr_filter_cutoff and full_rank_corr_filter_cutoff as parameters
- Set screen_significant default to TRUE
- Clean up indentation and simplify control flow
…lter optional - Add screen_method parameter to allow choosing between qvalue/fdr screening - Make pre_filter_by_pqr optional (default FALSE) to skip p-value pre-filtering - Expose initial_corr_filter_cutoff and full_rank_corr_filter_cutoff as parameters - Set screen_significant default to TRUE - Clean up indentation and simplify control flow Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.