Conversation
Collaborator
77ph
commented
Jul 14, 2025
77ph
commented
- Internal audit
8ball030
reviewed
Jul 14, 2025
| Sending native tokens to a contract changes the balance, but does not change the variables. | ||
| Not checked msg.value vs roundPoints[curRound].minDonation | ||
| I recommend removing the function if it has no other use or limiting it to the owner only. | ||
| ``` |
| ### Low: No emit | ||
| ``` | ||
| No emit in withdrawIncentiveTokenBalance() | ||
| ``` |
| Before using other tokens, check their behavior on call approve(0). | ||
| Ref: | ||
| ``` | ||
| IToken(incentiveTokenAddress).approve(permit2, 0); |
Contributor
There was a problem hiding this comment.
Is this a problem?
Or can the current implementation be left as id like to basically add a new function to swap out the incentivised pool
Will this break other tokens?
Collaborator
Author
There was a problem hiding this comment.
No problem. Just notes.
Perhaps such tokens exist where it is not allowed to do approve(0) - but I don't know any like that.
8ball030
reviewed
Jul 14, 2025
| ### Medium: withdrawIncentiveTokenBalance() | ||
| You can't take away by owner what has already been promised for rewards and donations have already been made in round - 1. | ||
| ``` | ||
| uint256 claimRound = currentRound - 1; |
Contributor
8ball030
reviewed
Jul 18, 2025
| Confusing calculations. Actually the point is that if `roundToClaimed[claimRound][account] > 0` then you need to return 0. | ||
| ``` | ||
| uint256 amount = (donation * roundPoints[claimRound].availableRewards) / totalRoundDonations; | ||
| uint256 claimedAmount = roundToClaimed[claimRound][account]; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.