Open
Conversation
Used Enumerations for Constants: Enumerations provide clearer and more organized constant definitions compared to plain integer constants. Replaced Magic Constants: Magic constants are hard to understand and maintain, so replacing them with named constants improves code readability and clarity. Refactored Round Functions: Refactoring long and repetitive macros into separate functions improves code modularity and readability. Used Bitwise Operators Instead of Macros: Using bitwise operators simplifies code and reduces redundancy compared to defining macros for each hex value. Improved Comments: Clear comments help developers understand code functionality, facilitating easier maintenance and debugging. Next commit will be optimizing checksum (if this is approved) to optimize performance algorithmically.
QuannWright
approved these changes
Jun 30, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Used Enumerations for Constants: Enumerations provide clearer and more organized constant definitions compared to plain integer constants.
Replaced Magic Constants: Magic constants are hard to understand and maintain, so replacing them with named constants improves code readability and clarity.
Refactored Round Functions: Refactoring long and repetitive macros into separate functions improves code modularity and readability.
Used Bitwise Operators Instead of Macros: Using bitwise operators simplifies code and reduces redundancy compared to defining macros for each hex value.
Improved Comments: Clear comments help developers understand code functionality, facilitating easier maintenance and debugging.
Next commit will be optimizing checksum (if this is approved) to optimize performance algorithmically.