Skip to content

Conversation

@jumbocarrot0
Copy link
Contributor

@jumbocarrot0 jumbocarrot0 commented Oct 12, 2025

Adds a small bit of code to SMODS.scale_card that checks if any cards have an edition with the calc_scaling function. This allows editions to modify the scaling effect of cards like jokers can.

Additional Info:

  • I didn't modify api's or I've made a PR to the wiki repo.
  • I didn't modify api's or I've updated lsp definitions.
  • I didn't make new lovely files or all new lovely files have appropriate priority.

@english5040
Copy link
Collaborator

alright, agreed that this is a good addition.

I'm concerned (outside of this specific PR) that we have many different things happening in calc, each of which is passed to an inconsistent subset of objects. Better Calc is good at passing things to every relevant cardarea but there still are gaps

@SleepyG11 SleepyG11 mentioned this pull request Nov 21, 2025
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants