Custom StatusText in update_hand_text
#1172
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds the ability of set a custom `StatusText` value in the `update_hand_text` and `SMODS.upgrade_poker_hands` functions
Added StatusText parameter to upgrade_poker_hands function
Gloompashcy
requested review from
Aurelius7309,
Eremel and
GauntletGames-2086
as code owners
Member
Aurelius7309
left a comment
Aurelius7309
left a comment
There was a problem hiding this comment.
Looks good. However you missed the main util function this actually gets used in, being level_up_hand. That function neeeds to support the new feature as well. Also I'm not quite happy with the way StatusText can be passed in, due to SMODS.upgrade_poker_hands not just handling multiple parameters, but also multiple hands. For this reason, I think StatusText should be allowed to be a function that depends on the hand and parameter, but not a nested table (what if a geniuine key in StatusText overlaps with a scoring parameter?). Said function should of course handle both strings and tables.
`level_up_hand` and `SMODS.smart_level_up_hand` now take `statustext` as an argument `args.StatusText` in `SMODS.upgrade_poker_hands` can now be a function This function takes the key of a hand and a scoring parameter as arguments and can return a string, table or boolean value
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the ability to set a custom
StatusTextvalue in theupdate_hand_textandSMODS.upgrade_poker_handsfunctionsAdditional Info: