Conversation
Introduce a Difficulty enum with ReadFrom/WriteTo and serde support. Add World accessors/mutators for difficulty and difficulty lock. Add serverbound SChangeDifficulty and clientbound CChangeDifficulty packets and export them. Send current difficulty to clients during login.
Introduce FoodData with hunger, saturation, exhaustion, tick logic and tests. Integrate the module into the player code and adjust imports. Add CUpdateAttributes and SPlayerCommand packets and register protocol modules.
|
Be honest, how much of this is pure ai? |
|
not much, just all of the docs and some functions which i then took a look and made them (hopefully) better |
CuzImClicks
left a comment
CuzImClicks
left a comment
There was a problem hiding this comment.
Im sorry bro im not trying to be mean, but im just not buying it. Did you have an agent jzst retroactively add comments to every second line? 50% of the changes in your pr are just ai comments. If youre gonna write comments, write them yourself, because only then will you realise what actually provides value to the reader of that comment.
When writing comments you should also always assume the reader is not dumb, just uneducated.
I don't think this is completely fair, although I must say the validity of those comments depends entirely on the specific workflow joni chose; I personally also use AI for doc comments, as it is literally ideal for this task. Of course, you should always thoroughly rework/correct/de-shittify them, so let's hope he did that (I haven't read them) :D |
|
i mean cuzimclicks is kind of right, i forgot to clean up comments and forgot to revert those changed the ai did where it modified the comments |
This reverts commit 356ade3.
|
This pull request has conflicts with the base branch "master". Please resolve those so we can test out your changes. |
|
Conflicts have been resolved! 🎉 |
|
This PR requires the Attribute system to be implemented before it can get merged. It depends on it but currently just uses a hardcoded network id. I don't want any code to build on top of foundations that are non-exsistent so this PR will be halted until we have implemented a proper Attribute system. |
|
This pull request has conflicts with the base branch "master". Please resolve those so we can test out your changes. |
|
awww fuck me |
|
Conflicts have been resolved! 🎉 |
|
This pull request has conflicts with the base branch "master". Please resolve those so we can test out your changes. |
4 participants
i am hungry now