Skip to content

Fix update-minecraft-src.sh script for MacOS#154

Open
Morb0 wants to merge 2 commits intoSteel-Foundation:masterfrom
Morb0:bugfix/fix-macos-update-minecraft-script
Open

Fix update-minecraft-src.sh script for MacOS#154
Morb0 wants to merge 2 commits intoSteel-Foundation:masterfrom
Morb0:bugfix/fix-macos-update-minecraft-script

Conversation

@Morb0
Copy link
Copy Markdown

@Morb0 Morb0 commented Apr 1, 2026

Summary

  • Fix sed -i compatibility in update-minecraft-src.sh for macOS
    • macOS sed requires a backup extension argument, unlike GNU sed
    • Use sed -i.bak which works on both macOS and Linux

@4lve
Copy link
Copy Markdown
Collaborator

4lve commented Apr 1, 2026

I'm not sure if this version pinning is required anymore with the latest GitCraft version. Could you try removing it completely?

@Morb0
Copy link
Copy Markdown
Author

Morb0 commented Apr 1, 2026

I'm not sure if this version pinning is required anymore with the latest GitCraft version. Could you try removing it completely?

Removed the groovy version pin - you were right, it's not needed anymore.
But there was other issue with loom_version = 1.+ resolving to 1.16.0-alpha.16, which changed TinyJavadocProvider constructor API and broke the build.
So I pinned loom_version to 1.15.5 (latest stable) instead.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants