CSS and JS Minification and package.json update#11
Open
chiho13 wants to merge 3 commits intoStephenGrider:masterfrom
Open
CSS and JS Minification and package.json update#11chiho13 wants to merge 3 commits intoStephenGrider:masterfrom
chiho13 wants to merge 3 commits intoStephenGrider:masterfrom
Conversation
My Imgur Browser loads much faster first time round. Uglifier cuts JS file size by 90%.
For "gulp-cssnano": "^2.1.0",
"gulp-rename": "^1.2.2",
"gulp-uglify": "^1.5.1",
Owner
|
@chiho13 This looks good, 2 comments:
|
Author
|
do you mean the css minification and js uglify should be one task? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think the most useful change is the ability for learners to minify main.js file, especially when they want to deploy the app. It reminds them what is good practice by keeping the total size of web app less than ~1.5 MB. It also saves a lot of initial loading time for visitors.