Use __version__ for syslog identification#22
Merged
SteveEasley merged 1 commit intoSteveEasley:mainfrom Apr 15, 2026
Merged
Conversation
PR SteveEasley#21 used importlib.metadata.version() to look up the package version at runtime for the syslog identification message. This fails with PackageNotFoundError in PyInstaller deployments because PyInstaller strips dist-info metadata by default. kaleidescape.__version__ is the actual source of truth for the version (pyproject.toml reads from it via setuptools.dynamic), and works in all environments — pip installs, git URL installs, and PyInstaller bundles. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
robotdan
force-pushed
the
fix/syslog-version-lookup
branch
from
e897614 to
74f4d0e
Compare
Owner
|
Just a heads up I will be out of town till Tuesday of next week. Will look when I get back. |
robotdan
added a commit
to robotdan/pykaleidescape
that referenced
this pull request
May 6, 2026
test_send_syslog_identification_uses_dunder_version (PR SteveEasley#22) patched `kaleidescape.device.__version__`, which doesn't exist as a module attribute — `device.py` does `from . import __version__` inside `_send_syslog_identification`, making it a function-local. mock.patch requires the attribute to exist on the target, so the test failed with AttributeError. Patch `kaleidescape.__version__` (the real location) instead. The function's `from . import __version__` re-reads it on each call, so the patched sentinel propagates through. This test never executed in CI before merge because PR SteveEasley#22's runs were cancelled at the 6h job timeout (the same hang fixed in this PR). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
SteveEasley
pushed a commit
that referenced
this pull request
May 6, 2026
PR #18 (Refresh device state after auto-reconnect) added two tests that wait on `connect_signal` (STATE_CONNECTED) after the initial connect. PR #19 (Dispatch STATE_CONNECTED only on auto-reconnect) then moved the STATE_CONNECTED dispatch out of `_connect()` and into `_reconnect()`. PR #19 updated other tests with the same pattern, but #19 was opened before #18 merged, so the two tests added by #18 weren't updated. Result: `await connect_signal.wait()` after initial connect waits forever, hanging CI for the full 6h job timeout. Every CI run on main since #18 has been cancelled this way (#19, #20, #21, v1.1.6, #22). Match the pattern used by other tests updated in #19: assert `state == STATE_CONNECTED` directly after the initial connect, and keep `connect_signal.wait()` only for the post-reconnect signal where STATE_CONNECTED is actually dispatched. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes
PackageNotFoundErrorin_send_syslog_identificationwhen running in PyInstaller-bundled deployments.PR #21 used
importlib.metadata.version("pykaleidescape")to look up the package version at runtime. This was a reasonable approach but doesn't work in environments where package dist-info metadata isn't available — notably PyInstaller, which strips it by default.kaleidescape.__version__is already the single source of truth for the version (pyproject.toml reads from it via[tool.setuptools.dynamic]), so using it directly is both simpler and universally compatible.