2 new options + Trigger the mention autocomplete even when there are characters after the delimiter#68
Open
Kobee1203 wants to merge 3 commits intoStevenDevooght:masterfrom
Open
2 new options + Trigger the mention autocomplete even when there are characters after the delimiter#68Kobee1203 wants to merge 3 commits intoStevenDevooght:masterfrom
Kobee1203 wants to merge 3 commits intoStevenDevooght:masterfrom
Conversation
added 2 commits
September 20, 2017 18:54
… the delimiter. Refactoring to override the default behavior. New options: - triggerRegex: regex (string or RegExp object) to Allow autocomplete if the preceding text matches the trigger regex. The default allows autocomplete after punctuation characters or whitespaces - canTriggerAutocomplete: function which returns a boolean and indicate when the autocomplete is triggered. The default allows autocomplete : - when there is an active selection (see StevenDevooght#65) - when there are characters after the delimiter (new condition) - if the text preceding the delimiter matches the regex defined by 'triggerRegex'
Kobee1203
changed the title
… the delimiter. fix test 'cancel out': append a whitespace before entering a new mention. We don't allow to trigger the autocomplete if there is any character before the delimiter '@'
Kobee1203
force-pushed
the
trigger_options
branch
from
fc6765b to
788bb9d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Trigger the mention autocomplete even when there are characters afte the delimiter :
In tinymce, enter the text "hello", then return before this text and hit @ to insert a mention : the autocomplete does not trigger
I refactored to add the new behavior and add 2 options to override this default behavior :
- triggerRegex: regex (string or RegExp object) to allow autocomplete if the preceding text matches the trigger regex. The default allows autocomplete after punctuation characters or whitespaces
- canTriggerAutocomplete: function which returns a boolean and indicate when the autocomplete is triggered. The default allows autocomplete :
- when there is an active selection (see #65)
- when there are characters after the delimiter (new condition)
- if the text preceding the delimiter matches the regex defined by 'triggerRegex'