Skip to content

Quote CLI path in desktop launcher for Windows paths with spaces#7

Merged
astickleyid merged 1 commit intocodex/customize-agent-for-long-term-memory-and-context-b1zvhsfrom
copilot/sub-pr-4
Nov 15, 2025
Merged

Quote CLI path in desktop launcher for Windows paths with spaces#7
astickleyid merged 1 commit intocodex/customize-agent-for-long-term-memory-and-context-b1zvhsfrom
copilot/sub-pr-4

Conversation

Copy link
Copy Markdown

Copilot AI commented Nov 15, 2025

The desktop launcher fails on Windows when the project directory contains spaces (e.g., C:\Users\John Doe\...) because the unquoted path passed to spawn with shell: true is split by cmd.exe into multiple tokens.

Changes:

  • Wrap mastraBinary path in quotes before passing to spawn to handle Windows paths with spaces
  • Ensures desktop app can launch the agent for Windows users with default user directories
// Before: fails with paths containing spaces
const cli = spawn(`${mastraBinary} agent`, ...)

// After: handles spaces correctly
const cli = spawn(`"${mastraBinary}" agent`, ...)

💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

Copilot AI changed the title [WIP] Address feedback on project overview and usage guide Quote CLI path in desktop launcher for Windows paths with spaces Nov 15, 2025
Copilot AI requested a review from astickleyid November 15, 2025 19:07
@astickleyid astickleyid marked this pull request as ready for review November 15, 2025 19:08
@astickleyid astickleyid merged commit 6717365 into codex/customize-agent-for-long-term-memory-and-context-b1zvhs Nov 15, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants