Include an implementation of Goldilocks field and tests for `FPMul` by hdvanegasm · Pull Request #76 · Stoffel-Labs/mpc-protocols

hdvanegasm · 2026-02-12T18:31:41Z

In this PR, I added:

Implementation for Goldilocks field.
Tests with Goldilocks field for random bit generation.
Unit tests for fixed-point multiplication.

Limits on the number of times a subprotocol can be executed as well as on other protocol-specific resources such as storage are set. Related to that, session IDs are checked to minimize the target surface for malicious messages. This means - protocol-specific checks such as sub ID == 0 - check that instance ID matches the one of the current instance To test session IDs, a preprocessing test with a lot of shares and triples has been added.

The network test only worked in release mode, probably because functions were blocking in threads (such as accept/recv) and these threads were cancelled, leading to cancelling while locks were still held. This is fixed by simply accepting/receiving once instead of infinitely. Additionally, some memory leaks are removed and appropriate freeing functions are added.

- implemented Pedersen commitments with basic tests. - Avss and Random share generation with avss - Rand() function added

Add automated CI pipeline with: - Build job (release mode) - Test job (all integration tests) - Lint job (rustfmt + clippy) Triggers on push to main/dev/feature branches and PRs. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

Replace incorrect action name 'dtolnay/rust-action@stable' with the correct 'dtolnay/rust-toolchain@stable' at lines 21, 45, and 68. This fixes the CI failure on PR #69. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

Applied cargo fmt and cargo clippy fixes across the codebase to ensure clean CI builds. Updated CI workflow to use targeted test command that runs only the stoffelmpc-mpc library tests. Changes: - CI: Updated test command from `cargo test` to `cargo test -p stoffelmpc-mpc --lib` - Formatting: Applied cargo fmt to 33 files across mpc/ and network/ crates - Linting: Fixed clippy warnings including unused imports, style issues - Added crate-level lint allows in mpc/src/lib.rs for acceptable style patterns Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

Ensures consistent Rust version between local development and CI to prevent environment-specific lint failures. Fixes unnecessary_unwrap clippy warning in bad_fake_network.rs by using if-let pattern. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

Use iterator pattern instead of index-based loop for cleaner code. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

- Implement missing `rand` trait method in HoneyBadgerMPCNode - Update SubProtocolCounters to use Mutex<Option<u8>> type - Add async .await to get_next() counter calls - Fix unused imports in pedersen.rs test module with #[cfg(test)] - Add LimitError variant to RandBitError enum - Update get_or_create_storage to return Result for session limits - Fix Box::from_raw to use drop() for proper memory freeing - Prefix unused sessionid variable with underscore - Fix test to properly check session storage limit Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

Replace fixed 500ms sleep with a polling loop that waits for specific conditions to be met. This fixes intermittent CI failures caused by the sleep not being long enough on slower machines. The polling loop checks every 50ms with a 10 second timeout, ensuring the test is both fast on fast machines and reliable on slow ones. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

…s-ci ci: Add GitHub Actions CI workflow (STO-386)

- Added a new mpc protocol for ADKG - Added triple generation, removed unnecessary traits, redefined feldman shares for avss mpc - Added multiplication for avss, tests,removed unused imports

- Added session ID trait, protocol specific message wrappers and corressponding changes

* Fixed-point and integer operations * division by constants, * preprocessing-storage traits * testing # Conflicts: # Cargo.toml # mpc/Cargo.toml # mpc/src/common/mod.rs # mpc/src/ffi/c_bindings/honey_badger_mpc_client/mod.rs # mpc/src/honeybadger/fpdiv/fpdiv_const.rs # mpc/src/honeybadger/fpmul/fpmul.rs # mpc/src/honeybadger/mod.rs # mpc/src/honeybadger/preprocessing.rs # mpc/tests/node_test.rs

This commit combines three PRs previously reviewed separately: 1. avoid premature clearing of messages 2. some testing improvements 3. some input improvements In more detail: 1. - See STO-177. 2. - better Debug impl for SessionId - avoid premature dropping of receivers - the same problem as STO-38. - avoid premature dropping of receiver - See STO-176. - make program exit on panic in any thread - add preprocessing_e2e test with BadFakeNetwork 3. - allow InputServer::init to be called before InputServer::input_handler - remove storage for random shares - only send masked inputs when reconstruction of random values has succeeded for the first time to avoid sending them multiple times - do not store more messages than 2t+1 to prevent a malicious node from spoofing sender IDs to act as if more nodes were sending random shares - add InputServer::wait_for_all_inputs, which either waits a given duration and then fails, or returns all inputs if they have arrived in this time; the previous solution used less encapsulation and always waited a fixed amount of time with no possibility to continue earlier - use one lock per InputClient instead of multiple - add some documentation

# Conflicts: # mpc/src/honeybadger/batch_recon/batch_recon.rs # mpc/src/honeybadger/fpmul/mod.rs # mpc/src/honeybadger/fpmul/rand_bit.rs # mpc/src/honeybadger/mod.rs # mpc/src/honeybadger/mul/multiplication.rs

During the addition of these tests, I found an error in truncation and fixed-point multiplication. Run the tests for more insights.

hdvanegasm · 2026-02-17T02:36:57Z

There are some fixes still pending. Those fixes are related to the use of AvssSessionId inside HoneyBadgerMPCNode. This PR is still work in progress.

The fix is not completed yet. I think that the routing for AVSS protocols is not yet ready.

hdvanegasm · 2026-02-26T22:27:22Z

All errors are now solved and the PR is ready to be reviewed.

GarryFCR · 2026-03-02T08:59:27Z

mpc/src/common/share/avss.rs

    SendError,
 }

+impl<F, G> SecretKey<F, Shamirshare<F>, G> for FeldmanShamirShare<F, G>


this has been deleted, its not required

GarryFCR · 2026-03-02T09:00:17Z

mpc/src/common/share/avss.rs

@@ -1,8 +1,10 @@
+use crate::avss_mpc::AvssSessionId;


dont use this session id type here, keep it generic. The reason this exists in common is so that other mpc protocols can use it and not only avss_mpc.

GarryFCR · 2026-03-02T09:08:29Z

mpc/src/common/mod.rs

    ) -> Result<Vec<Self::Sint>, Self::Error>;
 }

+pub trait SecretKey<F, S, G>


The following is not needed anymore

GarryFCR · 2026-03-02T09:16:56Z

mpc/src/honeybadger/fpmul/fpmul.rs

    pub output_channel: Sender<SessionId>,
 }

+#[derive(Debug)]


we wont need the store or state here, check out the channel-fixes branch its quite simplified.

GarryFCR · 2026-03-02T10:58:00Z

mpc/src/honeybadger/fpmul/mod.rs

+    pub share_r_2: Option<Vec<GF256>>,
+    pub share_b_2: Vec<GF256>,          //PrandBitD output
    pub share_b_p: Vec<RobustShare<G>>, //PrandBitD/PrandBitL output
+    pub protocol_state: ProtocolState,


this is also added in channel fixes

This is about the ProtocolState.

hdvanegasm · 2026-03-09T15:25:31Z

I will close this pull request as I think it is better to branch from dev and do the changes manually, and then merge back into dev. This will save me from resolving conflicts about other things that has nothing to do with my contribution with potential critical mistakes.

cadaniluk and others added 30 commits December 29, 2025 16:48

update C headers for FFI and fix memory leaks

8e84dff

Minimal traits for ADKG (#59)

cc78d9f

- implemented Pedersen commitments with basic tests. - Avss and Random share generation with avss - Rand() function added

ci: Add GitHub Actions CI workflow (STO-386)

3be5de0

Add automated CI pipeline with: - Build job (release mode) - Test job (all integration tests) - Lint job (rustfmt + clippy) Triggers on push to main/dev/feature branches and PRs. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

fix: Correct GitHub Action name in CI workflow

8c98745

Replace incorrect action name 'dtolnay/rust-action@stable' with the correct 'dtolnay/rust-toolchain@stable' at lines 21, 45, and 68. This fixes the CI failure on PR #69. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

chore: update CI step names to reflect pinned Rust version

449f7f9

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

fix: resolve clippy warnings in network crate test modules

3d34b67

Use iterator pattern instead of index-based loop for cleaner code. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

Merge branch 'dev' into feature/sto-386-mpc-protocols-ci

616466a

chore: move Instant import to test module where it's used

afb95ed

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

Merge pull request #69 from Stoffel-Labs/feature/sto-386-mpc-protocol…

1c46a45

…s-ci ci: Add GitHub Actions CI workflow (STO-386)

ADKG protocol (#68)

1b71db7

- Added a new mpc protocol for ADKG - Added triple generation, removed unnecessary traits, redefined feldman shares for avss mpc - Added multiplication for avss, tests,removed unused imports

Session ID trait and protocol specific wrappers (#70)

f0bbf57

- Added session ID trait, protocol specific message wrappers and corressponding changes

add free functions & delete unnecessary ManuallyDrop

8df45aa

Initial trait for the adkg functions

4a2400e

Initial trait for the adkg functions

fd22d4b

fix(acss): minor import changes in Pedersen

2d61dea

Avss and random share generation using avss, Testing pending

55dfda7

Avss happy path test,encryption of shares

0f42153

Happy path test for Ransha Avss, fixes

b8967d3

Added secret key,adkg traits,commitment generation fixes,test case

d642a5d

Removed irrelevant generics and traits

cdf1fb6

fix(goldilocks): Implementation of Goldilocks using Arkworks traits.

9cf4de8

fix(goldilocks): Implementation of the correct trait.

555c40f

hdvanegasm and others added 7 commits February 16, 2026 16:02

feat(test): Initial test for RandBit

38e7038

# Conflicts: # mpc/src/honeybadger/batch_recon/batch_recon.rs # mpc/src/honeybadger/fpmul/mod.rs # mpc/src/honeybadger/fpmul/rand_bit.rs # mpc/src/honeybadger/mod.rs # mpc/src/honeybadger/mul/multiplication.rs

simple test fix

ec9f748

feat(test): Added test for PRandBitD

e72f2b2

feat(test): Added test for TruncPr

3d11c04

feat(test): Added tests for FMul.

08b5df4

During the addition of these tests, I found an error in truncation and fixed-point multiplication. Run the tests for more insights.

feat(test): Finished tests for FMul.

0ae8ed1

merge: Finished git rebase. Some fixes are needed.

2e1029d

hdvanegasm force-pushed the small-field branch from 6f2fa8f to 2e1029d Compare February 17, 2026 02:25

chore: removed .idea folder

26931ca

hdvanegasm requested review from GarryFCR and removed request for GarryFCR February 17, 2026 02:27

hdvanegasm added 5 commits February 17, 2026 09:57

fix(honeybadger): partial fix to routing of protocols.

e30364b

The fix is not completed yet. I think that the routing for AVSS protocols is not yet ready.

fix(honeybadger): partial fix to routing of protocols.

43b9d15

The fix is not completed yet. I think that the routing for AVSS protocols is not yet ready.

fix(honeybadger): correction of curve generics.

fe43493

The fix is not completed yet. I think that the routing for AVSS protocols is not yet ready.

fix(honeybadger): correction of rbc.

dcc2aac

fix(honeybadger): correction of rand bit and tests.

52d5921

hdvanegasm requested review from GarryFCR and Mikerah February 26, 2026 22:27

hdvanegasm added 2 commits February 26, 2026 17:42

chore: fix code formating.

7593437

chore: fix code to comply with clippy.

74332f0

GarryFCR reviewed Mar 2, 2026

View reviewed changes

GarryFCR force-pushed the dev branch from 7c33c34 to e949da2 Compare March 6, 2026 15:20

hdvanegasm closed this Mar 9, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Include an implementation of Goldilocks field and tests for `FPMul`#76

Include an implementation of Goldilocks field and tests for `FPMul`#76
hdvanegasm wants to merge 47 commits intodevfrom
small-field

hdvanegasm commented Feb 12, 2026

Uh oh!

hdvanegasm commented Feb 17, 2026

Uh oh!

hdvanegasm commented Feb 26, 2026

Uh oh!

GarryFCR Mar 2, 2026

Uh oh!

GarryFCR Mar 2, 2026

Uh oh!

GarryFCR Mar 2, 2026

Uh oh!

GarryFCR Mar 2, 2026

Uh oh!

GarryFCR Mar 2, 2026

Uh oh!

hdvanegasm Mar 9, 2026

Uh oh!

hdvanegasm commented Mar 9, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

hdvanegasm commented Feb 12, 2026

Uh oh!

hdvanegasm commented Feb 17, 2026

Uh oh!

hdvanegasm commented Feb 26, 2026

Uh oh!

GarryFCR Mar 2, 2026

Choose a reason for hiding this comment

Uh oh!

GarryFCR Mar 2, 2026

Choose a reason for hiding this comment

Uh oh!

GarryFCR Mar 2, 2026

Choose a reason for hiding this comment

Uh oh!

GarryFCR Mar 2, 2026

Choose a reason for hiding this comment

Uh oh!

GarryFCR Mar 2, 2026

Choose a reason for hiding this comment

Uh oh!

hdvanegasm Mar 9, 2026

Choose a reason for hiding this comment

Uh oh!

hdvanegasm commented Mar 9, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants