Skip to content

Conversation

@Smaedd
Copy link
Member

@Smaedd Smaedd commented Jan 1, 2026

Allows configuring the different components of lighting independently

@TeamSpen210
Copy link

Should probably keep the original keyvalue there, so users can tell what options they had their exisiting lights set to. Description could explain how backward compatibility works, and how to migrate your options.

@ozxybox
Copy link
Member

ozxybox commented Jan 1, 2026

Would be nice if we added something similar to readonly & report but for deprecating. Hidden field by default unless it exists on the entity

@Smaedd
Copy link
Member Author

Smaedd commented Jan 1, 2026

Yeah I think until we have that I'd much prefer removing the KV from the FGD entirely, it still functions as normal but experience has told me that having a KV means people will use it even when they shouldn't

@TeamSpen210
Copy link

Problem then is that less-technical users would open Hammer, and just see an obtuse _lightmode = 2 keyvalue, then have to guess/remember what they set the ent to before. Could discourage usage by making it integer not choices so you get numeric dropdowns. Or rename it to "preset", have a new "custom" field which makes the other options take effect.

Though, if we're adding new FGD features, I'd suggest it'd be good to have a way to specify a default value for existing entities without the keyvalue, separate to the default when placing new entities. So then you could migrate an option but keep the existing ents working, like here, keep 'static' for existing ents, use 'custom' for new ones.

@ozxybox
Copy link
Member

ozxybox commented Jan 1, 2026

Different default values for new entities compared to existing entities? Are you sort of proposing like versioning somehow?

@Smaedd
Copy link
Member Author

Smaedd commented Jan 1, 2026

I would hope there aren't too many of those less technical users in our closed beta, I think it's also fine to have the migration process documented somewhere but I'm pretty hesitant to have that place be the FGD itself, unless there's some special way to represent it that prevents issues like Ozxy was suggesting

@kiddu25
Copy link

kiddu25 commented Jan 1, 2026

can the process of porting even describe how it's work the new Kv should be write on the wiki ? So like people when they ask how it's work the new ways, you can redirect people into the wiki?

Allows configuring the different components of lighting independently
@Smaedd Smaedd force-pushed the feat/independent-light-modes branch from 3d87fcf to 7803c35 Compare January 1, 2026 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants