Gps fix #56
Merged
Gps fix #56
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge pull request #50 from StrategFirst/dev
Merge pull request #51 from StrategFirst/dev
Merge pull request #53 from StrategFirst/dev
In some edge case picture might lack of a proper clean title this needs to be handle properly, a cleaner way would be to move on to a fully structured project with type maybe typescript to avoid undefined or null values
Enhanced crawling for the GPS coords Bing is gradually introducing more and more requirements to get those info, we need to follow them For further information about the hisotry please check the related Pull Request
StrategFirst
had a problem deploying
to
sonarcloud-analysis
GitHub Actions
Failure
StrategFirst
had a problem deploying
to
sonarcloud-analysis
GitHub Actions
Failure
StrategFirst
had a problem deploying
to
sonarcloud-analysis
GitHub Actions
Failure
The old github action was deprecated moving on the new recommended one!
StrategFirst
had a problem deploying
to
sonarcloud-analysis
GitHub Actions
Failure
StrategFirst
temporarily deployed
to
sonarcloud-analysis
GitHub Actions
Inactive
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GPS Crawling Fix & Enhancements
Fixes
Explanation
GPS Crawler
Over time Bing is introducing further and further requirements for their page being fetched, probably to avoid bots & crawler like this one from basically crawling their data.
As a quick recap in history :
User-Agentas non-empty was required, any value was acceptedUser-Agentmust be closer to the official formatHowever, even Mozilla official wiki say's that this is a bad thing to rely on.. We of course aren't giving a real config and continue trolling them a bit (see changes).
SonarQube
Deprecation made old SonarCloud github action deprecated an update was required, this pull request was the right time to adjust and enhance a bit those, however this pull request won't the place were additional issues and code quality and hotspot will be fixed, this will require another PR.