Skip to content

feat(backend): introduce transaction submission abstraction#73

Merged
greatest0fallt1me merged 2 commits intoStreampay-Org:mainfrom
Oluwaseyi89:feature/Horizon-or-RPC-transaction-submission-service
Apr 1, 2026
Merged

feat(backend): introduce transaction submission abstraction#73
greatest0fallt1me merged 2 commits intoStreampay-Org:mainfrom
Oluwaseyi89:feature/Horizon-or-RPC-transaction-submission-service

Conversation

@Oluwaseyi89
Copy link
Copy Markdown
Contributor

Pull Request: Add Horizon/RPC Transaction Submission Service

Implements transaction submission service as specified in #18.

Changes

  • TransactionService: Build, sign, and submit transactions to Horizon/RPC
  • Two signer modes: backend_sign (dev only) and external_signer (production)
  • Environment-based config with strict validation
  • Mocked tests covering success/failure paths

Security

  • Private keys never logged
  • Production blocks backend signing mode
  • XDR mode enables KMS/hardware wallet integration

Test Coverage: 97.3%

Closes #18

Body:

- add transaction submission service for Horizon/RPC flows
- support external_signer and backend_sign modes
- enforce signer env trust model (dev seed only, KMS required in non-dev backend signing)
- add mocked tests for success and failure paths (including redaction)
- document signer modes and security model in README
@drips-wave
Copy link
Copy Markdown

drips-wave bot commented Mar 30, 2026

@Oluwaseyi89 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

@Oluwaseyi89 Oluwaseyi89 marked this pull request as draft March 30, 2026 11:28
@Oluwaseyi89 Oluwaseyi89 changed the title feat(backend): introduce transaction submission abstraction (draft) feat(backend): introduce transaction submission abstraction Mar 31, 2026
@Oluwaseyi89 Oluwaseyi89 marked this pull request as ready for review March 31, 2026 06:52
@greatest0fallt1me greatest0fallt1me merged commit 97287e3 into Streampay-Org:main Apr 1, 2026
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Horizon (or RPC) transaction submission service

2 participants