Skip to content

Comments

refactor: remove artificial loading delays and spinners from service listings#244

Merged
james-cross merged 1 commit intostagingfrom
refactor/remove-artificial-loading-delays
Feb 17, 2026
Merged

refactor: remove artificial loading delays and spinners from service listings#244
james-cross merged 1 commit intostagingfrom
refactor/remove-artificial-loading-delays

Conversation

@james-cross
Copy link
Collaborator

Summary

Remove intentional delayed loading states and spinner animations from service cards and organisation service accordions. These were originally added to simulate loading when navigating to organisation pages and switching between locations, but are no longer needed now that service information appears inline below selected locations.

Changes

  • Remove loadingCardId state and handleCardClick with its 3-second setTimeout from ProgressiveServiceGrid
  • Remove isLoading and onCardClick props from ServiceCard and GroupedServiceCard
  • Remove loadingContent state and 800ms setTimeout from OrganisationServicesAccordion location switching
  • Remove spinner overlay and opacity transition wrappers from service detail sections
  • Remove .loading-card CSS styles and associated keyframe animations (loading-border, loading-pulse, loading-shimmer) from globals.css

Testing

  • TypeScript compilation passes with no errors
  • All 465 unit tests pass (3 pre-existing sitemap test failures unrelated to these changes)
  • ESLint passes with no warnings or errors

@james-cross james-cross merged commit 3787f32 into staging Feb 17, 2026
6 checks passed
@james-cross james-cross deleted the refactor/remove-artificial-loading-delays branch February 17, 2026 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant