refactor: centralise config constants, cache headers, and env vars#248
Merged
james-cross merged 1 commit intostagingfrom Feb 18, 2026
Merged
refactor: centralise config constants, cache headers, and env vars#248james-cross merged 1 commit intostagingfrom
james-cross merged 1 commit intostagingfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Centralise magic values, hardcoded strings, and environment variable access into dedicated config modules. This is implementation plan chunk 02 (Config Centralisation).
Changes
src/config/constants.tswith DB_NAME, API default limits, timeouts, cache TTLs, cache header strings, and no-cache response header objectssrc/config/env.tswith centralised environment variable access, validation helpers, and environment detection (isTest, isDev, isProd)client.db('streetsupport')calls withclient.db(DB_NAME)across API routes, helpers, repositories, and utilitiesCACHE_HEADERS.*constants across 12 API routesNO_CACHE_RESPONSE_HEADERSin 4 dynamic endpoints (banners, SWEP, logos, resources)process.env.NODE_ENV === 'test' || process.env.PLAYWRIGHT_TEST === '1'checks withenv.isTest()baseUrlin sitemap route into the handler to fix a test isolation issue exposed by the new importsTesting