refactor: use $facet to merge services count query into single pipeline#249
Merged
james-cross merged 1 commit intostagingfrom Feb 18, 2026
Merged
Conversation
- Replace two separate aggregate calls (results + count) with a single $facet pipeline - Remove dead $skip/$limit stages that were added then immediately stripped - Add comments explaining why pagination happens in JS (distance interleaving) - Document MAX_SERVICES_FETCH_LIMIT constant rationale
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The services API was running two separate MongoDB aggregate calls per request: one for results and one for count. This merges them into a single round trip using
$facet, and removes dead code that was adding pagination stages only to immediately strip them off.Changes
aggregate()calls with a single$facetpipeline that returns both results and count$skip/$limitstages that were added to the pipeline then spliced off before execution$skipand$limitfrom theAggregationStagetypeMAX_SERVICES_FETCH_LIMITconstant with its rationaleTesting