Skip to content

Conversation

@StrikeForceZero
Copy link
Owner

@StrikeForceZero StrikeForceZero commented Apr 24, 2017

Need to go through and remove chai references, then possibly swap out mocha and karma entirely

notes for myself when I come back to this:

https://github.com/react-boilerplate/react-boilerplate/blob/master/app/components/Img/tests/index.test.js#L36

<Img /> › should not adopt a srcset attribute

    TypeError: chai_1.expect(...).to.not.have.attr is not a function

      at Object.it (app\components\Img\tests\index.test.tsx:31:54)

related to #5

@StrikeForceZero StrikeForceZero changed the title [WIP] Add Jest #5 [WIP] Add Jest Apr 24, 2017
@StrikeForceZero StrikeForceZero changed the title [WIP] Add Jest Add Jest Apr 24, 2017
@StrikeForceZero StrikeForceZero self-assigned this Apr 24, 2017
@wer32
Copy link

wer32 commented Jun 15, 2017

Wow it works. I've migrate that pull request to my project. Thank you for your work!

@SimpleCookie
Copy link

I got nothing to add, just wanted to say good job! Keep at it.
I'm just about to give this repo a try. I'd love to contribute, but not sure if I can.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants