fix: update quoteClosePosition return type, bump to v0.4.1#36
Merged
Conversation
…romContract The quoteClosePosition contract function's first return value changed from bool to bytes in the updated ABI. Two of three call sites were updated (context.ts, open-position.ts) but the exported getPositionLiveDetailsFromContract in position.ts was missed. This caused error detection to silently fail for partial closes since viem returns a Hex string for bytes, which is always truthy when cast to boolean. Bumps version to 0.4.1.
koko1123
force-pushed
the
koko/fix-quote-close-position-041
branch
from
ea43921 to
7d572be
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
quoteClosePositionreturn type ingetPositionLiveDetailsFromContract(position.ts). The ABI changed the first return value frombool successtobytes unexpectedReason, but this exported function was not updated (unlikecontext.tsandopen-position.tswhich were).bytes, which is always truthy when cast toboolean, causing error detection to silently fail for partial closes.Test plan