STK-14383: Allow passing in ECR repository name #276
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR adds flexibility to the Docker build workflow by allowing custom ECR repository names and Docker build configurations. The primary purpose is to support building images with names different from their repository name, specifically for Kong.
Key changes:
- Added four new optional workflow inputs:
ecr_repository,dockerfile,context, andrun_tests - Modified ECR repository creation and Docker build steps to use the custom ECR repository name when provided
- Made RSpec testing optional through a conditional job execution
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
.github/workflows/docker-build.yml
Outdated
| required: false | ||
| default: false | ||
| type: boolean | ||
| ecr_repository: |
There was a problem hiding this comment.
The naming convention is inconsistent with other parameters in this workflow. All other multi-word parameters use kebab-case (e.g., bundle-no-assets, ruby-version, run-parallel-tests, run-job-per-folder), but this parameter uses snake_case. Consider renaming to ecr-repository for consistency.
| ecr_repository: | |
| ecr-repository: |
.github/workflows/docker-build.yml
Outdated
| required: false | ||
| type: string | ||
| default: "." | ||
| run_tests: |
There was a problem hiding this comment.
The naming convention is inconsistent with other parameters in this workflow. All other multi-word parameters use kebab-case (e.g., bundle-no-assets, ruby-version, run-parallel-tests, run-job-per-folder), but this parameter uses snake_case. Consider renaming to run-tests for consistency.
| run_tests: | |
| run-tests: |
2 participants
Link to Jira ticket
Purpose
We need to build an image that is not named the same as the repo it is in for Kong.
Approach
Allow passing in ECR repository name.