STK-14496: Add option to add additional port mappings #277
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
December 1, 2025 15:46
…ings - Added 'additional_port_mappings' parameter to allow supplementary port mappings without overriding automatic behavior. - Updated logic to incorporate additional port mappings when automatic port mapping is used.
- Introduced tests to verify the inclusion of additional port mappings alongside the main container port mapping. - Ensured that additional port mappings do not override automatic port mappings, maintaining expected behavior.
JoshuaGleason
approved these changes
Dec 1, 2025
Contributor
JoshuaGleason
left a comment
JoshuaGleason
left a comment
There was a problem hiding this comment.
Seems like it makes sense.
Why not just pass in port mappings?
Contributor
Author
Because that overrides the port mapping that connects to the target group that is created within this component (we can't reference it yet). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to Jira ticket
Purpose
Sometimes we need to supplement the existing 80/443 ports with additional ports on the same container.
Approach
Provide "additional_port_mappings" kwarg.
Testing
Added pytest.