Fix unreachable 5xx handling, enum-to-string crash, missing type mapping, and typos#166
Draft
Fix unreachable 5xx handling, enum-to-string crash, missing type mapping, and typos#166
Conversation
…t specifier, missing type mapping, and typos Co-authored-by: Structed <29922+Structed@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix issues found in the code
Fix unreachable 5xx handling, enum-to-string crash, missing type mapping, and typos
Feb 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Code audit surfaced four bugs and several typos across the addon.
Bug fixes
PlayFabHttp.gd: 5xx server error branch was unreachable —elif response_code >= 400matched all 4xx and 5xx before theif response_code >= 500check. Reordered:PlayFab.gd:_add_auth_headersconcatenated an enum int with a string (auth_type + "\""), causing a runtime type error. Wrapped instr().PlayFabClientConfigLoader.gd: Error message used%finstead of%dfor an integer error code.LoginWithEmailAddressRequest.gd: Missing_get_type_for_property()override forInfoRequestParameters, sofrom_dict()deserialization of that sub-object would fail.LoginWithCustomIdRequestalready had this mapping.Typos
calback,iomplemented,verbaitim,Retieve,enxryption,paris— fixed in comments and user-facing strings across six files.Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.