Skip to content

Fix unreachable 5xx handling, enum-to-string crash, missing type mapping, and typos#166

Draft
Copilot wants to merge 2 commits intodevelopfrom
copilot/fix-code-issues
Draft

Fix unreachable 5xx handling, enum-to-string crash, missing type mapping, and typos#166
Copilot wants to merge 2 commits intodevelopfrom
copilot/fix-code-issues

Conversation

Copy link

Copilot AI commented Feb 27, 2026

Code audit surfaced four bugs and several typos across the addon.

Bug fixes

  • PlayFabHttp.gd: 5xx server error branch was unreachable — elif response_code >= 400 matched all 4xx and 5xx before the if response_code >= 500 check. Reordered:

    elif response_code >= 500:
        emit_signal("server_error", path)
    elif response_code >= 400:
        # api_error handling
  • PlayFab.gd: _add_auth_headers concatenated an enum int with a string (auth_type + "\""), causing a runtime type error. Wrapped in str().

  • PlayFabClientConfigLoader.gd: Error message used %f instead of %d for an integer error code.

  • LoginWithEmailAddressRequest.gd: Missing _get_type_for_property() override for InfoRequestParameters, so from_dict() deserialization of that sub-object would fail. LoginWithCustomIdRequest already had this mapping.

Typos

calback, iomplemented, verbaitim, Retieve, enxryption, paris — fixed in comments and user-facing strings across six files.

Original prompt

are there any issues you can find in the code?


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

…t specifier, missing type mapping, and typos

Co-authored-by: Structed <29922+Structed@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix issues found in the code Fix unreachable 5xx handling, enum-to-string crash, missing type mapping, and typos Feb 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants