Claude/camper van control setup 011 c ups f knx2 j fyo e djhfgbz#3
Merged
StuartF303 merged 4 commits intomainfrom Nov 6, 2025
Merged
Conversation
…Phase 2 items 3 & 4) Backend Changes: - Add ToolbarPosition enum (Left, Right, Bottom) to SystemConfiguration - Initialize default toolbar position (Left) in SettingsService Frontend Changes: - Completely redesign MainLayout.razor with CSS Grid responsive layout - Support three toolbar positions: left sidebar, right sidebar, bottom bar - Auto-switch to bottom toolbar on screens < 600px width - Load toolbar position from settings API on app start Settings Page: - Add toolbar position selector with helpful labels - Left (Right-hand drive) - Right (Left-hand drive) - Bottom (Phone/Tablet) - Add mobile-responsive button layout Mobile Optimizations: - All pages (Index, Tanks, Controls, Settings) optimized for touch - Minimum touch target sizes: 48-56px (iOS/Android guidelines) - Larger buttons on mobile (full-width where appropriate) - Scaled controls (switches 1.5x, sliders larger) - Responsive typography and spacing - Tablet mode: icon-only navigation at 960px breakpoint - Phone mode: forced bottom navigation with full labels Dashboard: - Full-screen container replacing MudPaper - Larger edit mode toggle (48px minimum) - Improved status footer with medium-sized chips This completes Phase 2 requirements for touch-optimized tablet/phone interface with configurable toolbar positioning based on vehicle hand-drive preference.
Phone Orientation Behavior: - Portrait mode: Force bottom toolbar (regardless of settings) - Landscape mode: Use configured side toolbar (left/right based on settings) - Tablets: Use configured toolbar position from settings Media Query Updates: - Tablet (601-960px): Icon-only side navigation - Phone portrait (< 600px & portrait): Bottom toolbar with labels - Phone landscape (< 900px height & landscape): Side toolbar with icons only - Slim 70px width for landscape phones - Compact 60px height for bottom toolbar in landscape Settings Page: - Updated helper text to clarify orientation behavior - Improved labels: "Left Sidebar", "Right Sidebar", "Bottom Bar" - Note that portrait phones always use bottom toolbar This provides optimal ergonomics for all device orientations: - Portrait: Thumb-friendly bottom navigation - Landscape: Maximizes horizontal space with slim side toolbar - Tablets: Full configurability based on user preference
The < symbols in CSS comments were being interpreted by Razor as HTML tags, causing build errors: - RZ9980: Unclosed tag error - RZ10007: Duplicate attribute errors Changed: - '< 600px' to 'max 600px' - '< 900px' to 'max 900px' This fixes the GitHub Actions build pipeline errors.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.