Skip to content

🔧 Support pipe: true setting #165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
gretch wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

🔧 Support pipe: true setting #165

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
165459b
:wrench: Support pipe: true setting
gretch Oct 17, 2022
b36761d
:wrench: Support pipe: true setting
gretch Oct 17, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions lib/grover/js/processor.cjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,12 @@ const _processPage = (async (convertAction, urlOrHtml, options) => {
args: process.env.GROVER_NO_SANDBOX === 'true' ? ['--no-sandbox', '--disable-setuid-sandbox'] : []
};

// Configure puppeteer pipe options
const pipe = options.pipe; delete options.pipe;
if (pipe) {
launchParams.pipe = pipe;
}

// Configure puppeteer debugging options
const debug = options.debug; delete options.debug;
if (typeof debug === 'object' && !!debug) {
Expand Down