Skip to content

Perform the error handling for raise_request_on_failer before waiting for selectors / functions #202

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
feliperaul wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Perform the error handling for raise_request_on_failer before waiting for selectors / functions #202

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions lib/grover/js/processor.cjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -239,6 +239,15 @@ const _processPage = (async (convertAction, uriOrHtml, options) => {
await page.goto(displayUrl || 'http://example.com', requestOptions);
}

// Check for request errors immediately after navigation
if (requestErrors.length > 0) {
throw new GroverError("RequestFailedError", requestErrors);
}

if (pageErrors.length > 0) {
throw new GroverError("PageRenderError", pageErrors);
}

// add styles (if provided)
const styleTagOptions = options.styleTagOptions; delete options.styleTagOptions;
if (Array.isArray(styleTagOptions)) {
Expand Down