Skip to content

Add support for Ruby 4.0 #300

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gs-deliverists-io wants to merge 1 commit into
base: main
Choose a base branch
from
+16 −6
Open

Add support for Ruby 4.0 #300

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ jobs:
strategy:
fail-fast: false
matrix:
ruby-version: ['3.4']
ruby-version: ['4.0']
node-version: ['18']
puppeteer-version: [
'22.15.0',
Expand All @@ -40,6 +40,9 @@ jobs:
- ruby-version: '3.3'
node-version: '18'
puppeteer-version: '24.10.2'
- ruby-version: '3.4'
node-version: '18'
puppeteer-version: '24.10.2'
- ruby-version: '3.4'
node-version: '20'
puppeteer-version: '24.10.2'
Expand All @@ -49,7 +52,13 @@ jobs:
- ruby-version: '3.4'
node-version: '24'
puppeteer-version: '24.10.2'
- ruby-version: '3.5.0-preview1'
- ruby-version: '4.0'
node-version: '20'
puppeteer-version: '24.10.2'
- ruby-version: '4.0'
node-version: '22'
puppeteer-version: '24.10.2'
- ruby-version: '4.0'
node-version: '24'
puppeteer-version: '24.10.2'

Expand Down
3 changes: 2 additions & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,8 @@
# Changelog

## Unreleased
- none
### Added
- Add support for Ruby 4.0

## [1.2,4](releases/tag/v1.2.4) - 2025-11-04
### Added
Expand Down
2 changes: 1 addition & 1 deletion grover.gemspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ Gem::Specification.new do |spec|
SUMMARY
spec.homepage = 'https://github.com/Studiosity/grover'
spec.license = 'MIT'
spec.required_ruby_version = ['>= 3.0.0', '< 3.5.0']
spec.required_ruby_version = ['>= 3.0.0', '< 4.1.0']
Copy link

@ryansch ryansch Jan 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This constraint still feels pessimistic to me. Maybe < 5.0.0?


# Prevent pushing this gem to RubyGems.org by setting 'allowed_push_host', or
# delete this section to allow pushing this gem to any host.
Expand Down
4 changes: 2 additions & 2 deletions spec/spec_helper.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,11 +37,11 @@ def fixture_path(file)
end

def puppeteer_version_on_or_after?(version)
puppeteer_version.empty? || Gem::Version.new(puppeteer_version) >= Gem::Version.new(version)
puppeteer_version.nil? || puppeteer_version.empty? || Gem::Version.new(puppeteer_version) >= Gem::Version.new(version)
end

def puppeteer_version_on_or_before?(version)
puppeteer_version.empty? || Gem::Version.new(puppeteer_version) <= Gem::Version.new(version)
puppeteer_version.nil? || puppeteer_version.empty? || Gem::Version.new(puppeteer_version) <= Gem::Version.new(version)
end

def puppeteer_version
Expand Down