Add mustache/node test #1
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also tweak the output print newlines slightly so that each time ends up on its own line.
- JSON intermediate representation:
[
'<ul>',
[
'foreach',
{
data: 'items',
as: 'item',
tpl: [
'<li', ['attr',{id:id}], '>',
['text',{data:val}], '</li>'
]
}
],
'</ul>'
]
- small runtime with an interpreter and compiler
- ported two tests, both run faster than handlebars.js
* add comment explaining background * fix JSHint warnings, including one bug in the attr handler
* directly dereference static ids from scope without function call, but fall back to the full method for complex expressions * add jshintrc
* cache compiled sub-blocks by storing their options in a global cache keyed on uid; this means that we only compile each block once * remove some local var aliases for prototype members; these turn out not to be beneficial.
When a string was passed in, always include all children of body. Add test case.
When a string was passed in, always include all children of body. Add test case.
This avoids lots of extra string creation; we accumulate all the output in a single place from the beginning.
This port only required swapping out the handlebars module with hogan.js, and calling .render() on the compiled template. Lambda expressions are compiled in each iteration. There might be more efficient ways to do this in hogan, please contribute improvements!
The handlebars benchmark is not listed in runall.sh yet as it just excludes the timing of a plain .compile currently. Proper handlebars precompilation uses a commandline tool, but produces code that is very browser-specific. Making this work in node requires more tweaking.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.