Update README, samples and fix the project according to linters #25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shondll
approved these changes
Oct 31, 2025
Contributor
shondll
left a comment
shondll
left a comment
There was a problem hiding this comment.
Great many fixes. I am only concerned whether the linter will be too punishing on code updates
| if host is None: | ||
| print("Please set the PVS_HOST environment variable with the PVS IP.") | ||
| client.pvs_url = host # PVS URL with configurable host | ||
| client.pvs_url = f"http://{host}" # PVS URL with configurable host |
Contributor
Author
There was a problem hiding this comment.
I'm not sure if it will handle the self signed certificate without complains. So I decided to leave http.
shondll
reviewed
Oct 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.