-
Notifications
You must be signed in to change notification settings - Fork 174
SB-29916 | Added functionality for multi search feature #837
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: release-4.10.0
Are you sure you want to change the base?
SB-29916 | Added functionality for multi search feature #837
Conversation
|
Kudos, SonarCloud Quality Gate passed! |
|
@vinukumar-vs @maheshkumargangula - Please review this PR and merge. |
|
@vinukumar-vs @maheshkumargangula -- any update on this PR ? |
|
@karthik-tarento Please find the below discussion links to handle the multi-search/nested object filter |
I hope the above solution should work you as well. If it doesn't solve your requirement, lets discuss it detail about the requirement or share the JIRA story/ticket to understand better. |
|
@vinukumar-vs |
| filters.put("status", new ArrayList<String>()); | ||
| request.put("filters", filters); | ||
| Map<String, Object> multiFilters = new HashMap<>(); | ||
| multiFilters.put("competencies_v3.name", "CompetencyOne"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
multiFilters defined but not used.
| String groupByParent = (String) aggregationsMap.get("groupByParent"); | ||
| Terms terms = aggregations.get(groupByParent); | ||
| Terms terms = null; | ||
| List<Bucket> buckets = null; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Keep the previous implementation for buckets.
| searchSourceBuilder.aggregation(termBuilder); | ||
| } else { | ||
| if (nestedAggregation.get(groupByParent.split("\\.")[0]) != null) { | ||
| nestedAggregation.get(groupByParent.split("\\.")[0]).add(groupByParent.split("\\.")[1]); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See if we can assign groupByParent.split("\.")[0] to a variable and reuse it.








No description provided.