Skip to content

Create Particles for Route 53#90

Open
jophine-antony wants to merge 4 commits intodevelopfrom
CE-212-route53
Open

Create Particles for Route 53#90
jophine-antony wants to merge 4 commits intodevelopfrom
CE-212-route53

Conversation

@jophine-antony
Copy link
Copy Markdown
Contributor

@jophine-antony jophine-antony commented Apr 21, 2017

Particles created for route53 with following actions:

  • Create Hosted Zone
  • Create Record Set

RajkumarShivage
RajkumarShivage reviewed Apr 21, 2017
View reviewed changes
Comment thread managed-route53/README.md
-e ACCOUNTS="<accounts whose config policy will be monitored separated by spaces>"


## How To Update Lambda Function Codes
Copy link
Copy Markdown
Contributor

@RajkumarShivage RajkumarShivage Apr 21, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this needed?

Comment thread managed-route53/build.f/particles-initial/particles/cftemplates/route53HostedZone.json.hbs Outdated
{{parameter "optionalString" logicalId="RouteHostComment"}}

{{#resource "route53HostedZone" logicalId="Route53HostedZone" }}
"Properties": {
Copy link
Copy Markdown
Contributor

@RajkumarShivage RajkumarShivage Apr 21, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Properties should be part of resource definition. Can you move it to resource folder?

Comment thread managed-route53/build.f/particles-initial/particles/cftemplates/route53RecordSet.json.hbs Outdated
{{parameter "requiredString" logicalId="ResourceRecord" description="Value for Record Set Type" type="CommaDelimitedList"}}

{{#resource "route53RecordSet" logicalId="Route53RecordSet" type="AWS::Route53::RecordSet"}}
"Properties": {
Copy link
Copy Markdown
Contributor

@RajkumarShivage RajkumarShivage Apr 21, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Properties should be part of resource definition. Can you move it to resource folder?

@jophine-antony
Changes:
10ba659 
    * Modified particle to get hostedzone id as input/identifier to create
      recordset instead of hostedzone name. This is because, aws allows to
      create duplicate hostedzones with same name. Hence, hostedzone id was
      chosen to maintain uniqueness.
@RajkumarShivage
Copy link
Copy Markdown
Contributor

RajkumarShivage commented Jan 16, 2018

If this PR is not required, close it.

@SonalOjha
Copy link
Copy Markdown
Contributor

SonalOjha commented Mar 5, 2018

Can we discard this PR now.

@jophine-antony
Copy link
Copy Markdown
Contributor Author

jophine-antony commented Mar 5, 2018 via email

@jophine-antony
Copy link
Copy Markdown
Contributor Author

jophine-antony commented Mar 6, 2018 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@RajkumarShivage RajkumarShivage RajkumarShivage left review comments

@AlexOugh AlexOugh Awaiting requested review from AlexOugh

@bhargavapratik bhargavapratik Awaiting requested review from bhargavapratik

@sauravlahiri sauravlahiri Awaiting requested review from sauravlahiri

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@jophine-antony @RajkumarShivage @SonalOjha @AlexOugh @bhargavapratik