ci: enhance GetModuleVersion test #5
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hipska
requested changes
Dec 12, 2025
Member
Hipska
left a comment
Hipska
left a comment
There was a problem hiding this comment.
I almost didn't notice this PR. Please mention it on the main PR (Combodo#58) next time.
| $this->assertFalse(Utils::CheckModuleInstallation('fake-module', false, $oRestClient)); | ||
|
|
||
| $this->expectExceptionMessage('Required iTop module fake-module is considered as not installed due to: Found: 0'); | ||
| $this->assertFalse(Utils::CheckModuleInstallation('fake-module', true, $oRestClient)); |
Member
There was a problem hiding this comment.
Will this assert succeed given it will throw an exception?
Author
There was a problem hiding this comment.
my guess is that 'assertFalse' is useless. it will not fail as i will not be reached.
Member
There was a problem hiding this comment.
My idea as well, so it could have been replaced with this:
Suggested change
| $this->assertFalse(Utils::CheckModuleInstallation('fake-module', true, $oRestClient)); | |
| Utils::CheckModuleInstallation('fake-module', true, $oRestClient); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to speed up Combodo PR merge, i propose a test enhancement.