[pos_product_deposit] Add (bottle) deposit addon for PoS#1
Open
leonhandreke wants to merge 1 commit into12.0from
Open
[pos_product_deposit] Add (bottle) deposit addon for PoS#1leonhandreke wants to merge 1 commit into12.0from
leonhandreke wants to merge 1 commit into12.0from
Conversation
Contributor
leonhandreke
commented
Feb 13, 2022
leonhandreke
commented
leonhandreke
force-pushed
the
feature/product-deposit
branch
from
369ccbb to
c3deeb1
Compare
Contributor
|
It sometimes happens that the product is scanned twice accidentally. The PoS will merge the two items in one line with quantity 2. To remove one of the products, you can click on the delete button. This case might be problematic with this implementation, as you already wrote in a comment: removing the last product potentially only removes the deposit. |
leonhandreke
force-pushed
the
feature/product-deposit
branch
from
4f051f1 to
8d35efb
Compare
Contributor
Author
|
Thanks for the review. I discovered another (pretty obvious) bug while fixing this. Please take a look. |
leonhandreke
force-pushed
the
feature/product-deposit
branch
from
8d35efb to
c8df647
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.