Open
Conversation
…s to be flexible with capabilities
Theophile-Madet
requested changes
Mar 15, 2026
Collaborator
Theophile-Madet
left a comment
Theophile-Madet
left a comment
There was a problem hiding this comment.
Looks good!
Setting "request changes" just because of the tests and missing RecurringShiftWatch, otherwise it's fine, the comments are small style things.
Thanks for taking care of this,
# Conflicts: # tapir/translations/locale/de/LC_MESSAGES/django.po
Contributor
Author
|
I decided to add implementation for |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Should unblock #715
The EmailBuilder receives now a string to make it work.
@Theophile-Madet let me know if this could work and I will add some tests and implementation for
RecurringShiftWatch